Skip to content

Commit 0b51d5a

Browse files
committed
fix(core): declare vite-plus as optional peer
1 parent d3f6ac2 commit 0b51d5a

4 files changed

Lines changed: 19 additions & 0 deletions

File tree

packages/core/__tests__/build-artifacts.spec.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,16 @@ import { describe, expect, it } from 'vitest';
66

77
const coreDir = path.resolve(path.dirname(url.fileURLToPath(import.meta.url)), '..');
88
const distDir = path.join(coreDir, 'dist');
9+
const packageJsonPath = path.join(coreDir, 'package.json');
910

1011
describe('build artifacts', () => {
12+
it('should declare vite-plus as an optional peer for native binding resolution', () => {
13+
const pkg = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
14+
15+
expect(pkg.peerDependencies['vite-plus']).toBe(pkg.version);
16+
expect(pkg.peerDependenciesMeta['vite-plus']).toEqual({ optional: true });
17+
});
18+
1119
it('should include esm-shims.js in dist for tsdown shims support', () => {
1220
const shimsPath = path.join(distDir, 'esm-shims.js');
1321
expect(fs.existsSync(shimsPath), `${shimsPath} should exist`).toBe(true);

packages/core/build.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -759,12 +759,16 @@ async function mergePackageJson() {
759759
destPkg.peerDependencies = {
760760
...tsdownPkg.peerDependencies,
761761
...vitePkg.peerDependencies,
762+
'vite-plus': destPkg.version,
762763
};
763764

764765
// Merge peerDependenciesMeta from tsdown and vite
765766
destPkg.peerDependenciesMeta = {
766767
...tsdownPkg.peerDependenciesMeta,
767768
...vitePkg.peerDependenciesMeta,
769+
'vite-plus': {
770+
optional: true,
771+
},
768772
};
769773

770774
// `@tsdown/exe` and `@tsdown/css` are bundled into core (see bundleTsdown), so

packages/core/package.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,7 @@
150150
"typescript": "^5.0.0 || ^6.0.0",
151151
"unplugin-unused": "^0.5.0",
152152
"unrun": "*",
153+
"vite-plus": "0.2.2",
153154
"yaml": "^2.4.2"
154155
},
155156
"peerDependenciesMeta": {
@@ -203,6 +204,9 @@
203204
},
204205
"yaml": {
205206
"optional": true
207+
},
208+
"vite-plus": {
209+
"optional": true
206210
}
207211
},
208212
"optionalDependencies": {

pnpm-lock.yaml

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)