fix: copy .node NAPI bindings to binding/ instead of dist/

After merging packages/global into packages/cli, the NAPI loader at
binding/index.cjs uses require('./vite-plus.*.node') relative to itself,
so .node files must live in binding/ not dist/.

Author: fengmk2

crates/vite_global_cli/src/commands/upgrade/install.rs

@@ -34,19 +34,19 @@ const MAIN_PACKAGE_ENTRIES: &[&str] =
 ///
 /// From the platform tarball, extracts:
 /// - The `vp` binary → `{version_dir}/bin/vp`
-/// - Any `.node` files → `{version_dir}/dist/`
+/// - Any `.node` files → `{version_dir}/binding/`
 pub async fn extract_platform_package(
     tgz_data: &[u8],
     version_dir: &AbsolutePath,
 ) -> Result<(), Error> {
     let bin_dir = version_dir.join("bin");
-    let dist_dir = version_dir.join("dist");
+    let binding_dir = version_dir.join("binding");
     tokio::fs::create_dir_all(&bin_dir).await?;
-    tokio::fs::create_dir_all(&dist_dir).await?;
+    tokio::fs::create_dir_all(&binding_dir).await?;
 
     let data = tgz_data.to_vec();
     let bin_dir_clone = bin_dir.clone();
-    let dist_dir_clone = dist_dir.clone();
+    let binding_dir_clone = binding_dir.clone();
 
     tokio::task::spawn_blocking(move || {
         let cursor = Cursor::new(data);
@@ -81,8 +81,8 @@ pub async fn extract_platform_package(
                     std::fs::set_permissions(&target, std::fs::Permissions::from_mode(0o755))?;
                 }
             } else if file_name.ends_with(".node") {
-                // .node NAPI files go to dist/
-                let target = dist_dir_clone.join(file_name);
+                // .node NAPI files go to binding/ (alongside index.cjs loader)
+                let target = binding_dir_clone.join(file_name);
                 let mut buf = Vec::new();
                 entry.read_to_end(&mut buf)?;
                 std::fs::write(&target, &buf)?;

packages/cli/install.ps1

@@ -285,13 +285,15 @@ function Main {
     $VersionDir = "$InstallDir\$ViteVersion"
     $BinDir = "$VersionDir\bin"
     $DistDir = "$VersionDir\dist"
+    $BindingDir = "$VersionDir\binding"
     $CurrentLink = "$InstallDir\current"
 
     $binaryName = "vp.exe"
 
     # Create directories
     New-Item -ItemType Directory -Force -Path $BinDir | Out-Null
     New-Item -ItemType Directory -Force -Path $DistDir | Out-Null
+    New-Item -ItemType Directory -Force -Path $BindingDir | Out-Null
 
     # Download and extract native binary and .node files from platform package
     # Also copy JS bundle and assets
@@ -315,14 +317,14 @@ function Main {
             Write-Error-Exit "VITE_PLUS_LOCAL_BINARY must be set when using VITE_PLUS_LOCAL_TGZ"
         }
 
-        # Copy .node files if present
-        $nodeFilesPath = Join-Path $tempExtract "package" "dist"
+        # Copy .node files if present (NAPI bindings go to binding/ alongside index.cjs loader)
+        $nodeFilesPath = Join-Path $tempExtract "package" "binding"
         Get-ChildItem -Path $nodeFilesPath -Filter "*.node" -ErrorAction SilentlyContinue | ForEach-Object {
-            $destFile = Join-Path $DistDir $_.Name
+            $destFile = Join-Path $BindingDir $_.Name
             if (Test-Path $destFile) {
                 Remove-Item -Path $destFile -Force
             }
-            Copy-Item -Path $_.FullName -Destination $DistDir -Force
+            Copy-Item -Path $_.FullName -Destination $BindingDir -Force
         }
 
         # Copy JS assets
@@ -358,14 +360,14 @@ function Main {
                 Copy-Item -Path $binarySource -Destination $BinDir -Force
             }
 
-            # Copy .node files to DistDir (delete existing first to avoid system cache issues)
+            # Copy .node files to BindingDir (delete existing first to avoid system cache issues)
             $nodeFilesPath = Join-Path $platformTempExtract "package"
             Get-ChildItem -Path $nodeFilesPath -Filter "*.node" -ErrorAction SilentlyContinue | ForEach-Object {
-                $destFile = Join-Path $DistDir $_.Name
+                $destFile = Join-Path $BindingDir $_.Name
                 if (Test-Path $destFile) {
                     Remove-Item -Path $destFile -Force
                 }
-                Copy-Item -Path $_.FullName -Destination $DistDir -Force
+                Copy-Item -Path $_.FullName -Destination $BindingDir -Force
             }
 
             Remove-Item -Recurse -Force $platformTempExtract

packages/cli/install.sh

@@ -539,6 +539,7 @@ main() {
   VERSION_DIR="$INSTALL_DIR/$VITE_PLUS_VERSION"
   BIN_DIR="$VERSION_DIR/bin"
   DIST_DIR="$VERSION_DIR/dist"
+  BINDING_DIR="$VERSION_DIR/binding"
   CURRENT_LINK="$INSTALL_DIR/current"
 
   local binary_name="vp"
@@ -547,7 +548,7 @@ main() {
   fi
 
   # Create directories
-  mkdir -p "$BIN_DIR" "$DIST_DIR"
+  mkdir -p "$BIN_DIR" "$DIST_DIR" "$BINDING_DIR"
 
   # Download and extract native binary and .node files from platform package
   # Also copy JS bundle and assets
@@ -570,11 +571,11 @@ main() {
     fi
     chmod +x "$BIN_DIR/$binary_name"
 
-    # Copy .node files if present
-    for node_file in "$temp_dir"/dist/*.node; do
+    # Copy .node files if present (NAPI bindings go to binding/ alongside index.cjs loader)
+    for node_file in "$temp_dir"/binding/*.node; do
       if [ -f "$node_file" ]; then
-        rm -f "$DIST_DIR/$(basename "$node_file")"
-        cp "$node_file" "$DIST_DIR/"
+        rm -f "$BINDING_DIR/$(basename "$node_file")"
+        cp "$node_file" "$BINDING_DIR/"
       fi
     done
 
@@ -602,10 +603,10 @@ main() {
     cp "$platform_temp_dir/$binary_name" "$BIN_DIR/"
     chmod +x "$BIN_DIR/$binary_name"
 
-    # Copy .node files to DIST_DIR (delete existing first to avoid system cache issues)
+    # Copy .node files to BINDING_DIR (delete existing first to avoid system cache issues)
     for node_file in "$platform_temp_dir"/*.node; do
-      rm -f "$DIST_DIR/$(basename "$node_file")"
-      cp "$node_file" "$DIST_DIR/"
+      rm -f "$BINDING_DIR/$(basename "$node_file")"
+      cp "$node_file" "$BINDING_DIR/"
     done
     rm -rf "$platform_temp_dir"