Skip to content

Commit e1b7ced

Browse files
committed
fix(monaco): getDiagnostics throws "TypeError: response is not a function"
1 parent 2787b79 commit e1b7ced

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

packages/kit/lib/createChecker.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ function createTypeScriptCheckerWorker(
162162
fileName = asPosix(fileName);
163163
const uri = asUri(fileName);
164164
const languageService = getLanguageServiceForFile(fileName);
165-
return languageService.getDiagnostics(uri);
165+
return languageService.getDiagnostics(uri, () => { });
166166
}
167167

168168
async function fixErrors(fileName: string, diagnostics: Diagnostic[], only: string[] | undefined, writeFile: (fileName: string, newText: string) => Promise<void>) {

packages/language-service/lib/features/provideDiagnostics.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export function register(context: LanguageServiceContext) {
6262

6363
return async (
6464
uri: URI,
65-
response?: (result: vscode.Diagnostic[]) => void,
65+
response: ((result: vscode.Diagnostic[]) => void),
6666
token = NoneCancellationToken
6767
) => {
6868

@@ -123,7 +123,7 @@ export function register(context: LanguageServiceContext) {
123123

124124
function processResponse() {
125125
if (errorsUpdated && !updateCacheRangeFailed) {
126-
response?.(collectErrors());
126+
response(collectErrors());
127127
errorsUpdated = false;
128128
}
129129
}

packages/monaco/lib/editor.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,8 @@ export function activateMarkers(
9595
const token = createTokenForModelChange(model);
9696
const diagnostics = await languageService.getDiagnostics(
9797
getRequestId(token.token, languageService),
98-
model.uri
98+
model.uri,
99+
() => {}
99100
);
100101
token.dispose();
101102
if (token.token.isCancellationRequested) {

0 commit comments

Comments
 (0)