fix(monaco): getDiagnostics throws "TypeError: response is not a func…

…tion"
volarjs · Sep 7, 2024 · e1b7ced · e1b7ced
1 parent 2787b79
commit e1b7ced
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/packages/kit/lib/createChecker.ts b/packages/kit/lib/createChecker.ts
@@ -162,7 +162,7 @@ function createTypeScriptCheckerWorker(
 		fileName = asPosix(fileName);
 		const uri = asUri(fileName);
 		const languageService = getLanguageServiceForFile(fileName);
-		return languageService.getDiagnostics(uri);
+		return languageService.getDiagnostics(uri, () => { });
 	}
 
 	async function fixErrors(fileName: string, diagnostics: Diagnostic[], only: string[] | undefined, writeFile: (fileName: string, newText: string) => Promise<void>) {

diff --git a/packages/language-service/lib/features/provideDiagnostics.ts b/packages/language-service/lib/features/provideDiagnostics.ts
@@ -62,7 +62,7 @@ export function register(context: LanguageServiceContext) {
 
 	return async (
 		uri: URI,
-		response?: (result: vscode.Diagnostic[]) => void,
+		response: ((result: vscode.Diagnostic[]) => void),
 		token = NoneCancellationToken
 	) => {
 
@@ -123,7 +123,7 @@ export function register(context: LanguageServiceContext) {
 
 		function processResponse() {
 			if (errorsUpdated && !updateCacheRangeFailed) {
-				response?.(collectErrors());
+				response(collectErrors());
 				errorsUpdated = false;
 			}
 		}

diff --git a/packages/monaco/lib/editor.ts b/packages/monaco/lib/editor.ts
@@ -95,7 +95,8 @@ export function activateMarkers(
 		const token = createTokenForModelChange(model);
 		const diagnostics = await languageService.getDiagnostics(
 			getRequestId(token.token, languageService),
-			model.uri
+			model.uri,
+			() => {}
 		);
 		token.dispose();
 		if (token.token.isCancellationRequested) {