Skip to content

Example for agent_supported_features is misleading and breaks the YAML structure if followed verbatim #4682

Description

@cmontemuino

Description

https://github.com/volcano-sh/volcano/blob/v1.13.0/installer/helm/chart/volcano/values.yaml#L42

agent_supported_features: "OverSubscription\,Eviction\,Resources"

should be:

agent_supported_features: "OverSubscription,Eviction,Resources"

Steps to reproduce the issue

  1. Provide values override with agent_supported_features: "OverSubscription\,Eviction\,Resources"

Describe the results you received and expected

Non broken YAML structure

What version of Volcano are you using?

1.13.0

Any other relevant information

The Go pflag.StringSlice parser in the Volcano agent binary automatically splits on unescaped commas to create the array ["OverSubscription", "Eviction", "Resources"].

Escaping commas (\,) is needed only if the feature name itself contains a comma, which is not the case here.

The pflag parser will receive the comma-separated string and automatically split it into the three feature flags the agent expects.

Metadata

Metadata

Labels

kind/bugCategorizes issue or PR as related to a bug.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions