fix(session): pass memory_policy through CreateSessionOptions (#4495)

AsyncHTTPClient.create_session() takes (session_id, options); memory_policy
is a key of CreateSessionOptions, not a keyword argument. Three production
call sites still pass it as a keyword and raise

    TypeError: AsyncHTTPClient.create_session() got an unexpected keyword
    argument 'memory_policy'

on every session that does not already exist:

- openviking/ingest/replay.py, ConversationReplayClient.ensure_session:
  `ingest backfill` fails on every new session. The orchestrator catches
  per-session exceptions, so a first backfill prints one error per session
  and finishes with 0 commits.
- bot/vikingbot/openviking_mount/ov_server.py, VikingClient.ensure_session.
- openviking/session/train/components/session_commit.py,
  SessionCommitPolicyTrainer._commit_one, which swallows the TypeError and
  returns a failed commit record with an empty task_id.

All three now pass options={"memory_policy": policy}, and options=None when
no policy is configured. benchmark/locomo/vikingbot/import_to_ov.py already
used that form.

The three test fakes accepted the obsolete keyword, so none of the paths had
regression coverage. They now mirror the real SDK signature: reverting any
one of the three fixes fails its tests.

Fixes #4493

Author: haddadrm

bot/tests/test_openviking_api_key_type.py

@@ -54,8 +54,11 @@ def __init__(self, **kwargs):
     async def initialize(self):
         return None
 
-    async def create_session(self, session_id=None, memory_policy=None):
-        return {"session_id": session_id or "s-1", "memory_policy": memory_policy}
+    async def create_session(self, session_id=None, options=None):
+        return {
+            "session_id": session_id or "s-1",
+            "memory_policy": (options or {}).get("memory_policy"),
+        }
 
     async def session_exists(self, _session_id):
         return False
@@ -1896,9 +1899,9 @@ class NotFoundError(Exception):
     async def _get_session(_session_id):
         raise NotFoundError("Resource not found")
 
-    async def _create_session(session_id=None, memory_policy=None):
-        created.append((session_id, memory_policy))
-        return {"session_id": session_id, "memory_policy": memory_policy}
+    async def _create_session(session_id=None, options=None):
+        created.append((session_id, options))
+        return {"session_id": session_id, "memory_policy": (options or {}).get("memory_policy")}
 
     monkeypatch.setattr(client.client, "get_session", _get_session)
     monkeypatch.setattr(client.client, "create_session", _create_session)
@@ -1909,7 +1912,7 @@ async def _create_session(session_id=None, memory_policy=None):
     )
 
     assert result == {"session_id": "session-1", "memory_policy": {"strategy": "compact"}}
-    assert created == [("session-1", {"strategy": "compact"})]
+    assert created == [("session-1", {"memory_policy": {"strategy": "compact"}})]
 
 
 @pytest.mark.asyncio

bot/vikingbot/openviking_mount/ov_server.py

@@ -1169,7 +1169,7 @@ async def ensure_session(
 
         return await client.create_session(
             session_id=session_id,
-            memory_policy=memory_policy,
+            options={"memory_policy": memory_policy} if memory_policy else None,
         )
 
     @staticmethod

openviking/ingest/replay.py

@@ -68,7 +68,8 @@ async def ensure_session(
             return await self._client.get_session(ov_session_id)
         except NotFoundError:
             return await self._client.create_session(
-                session_id=ov_session_id, memory_policy=memory_policy or None
+                session_id=ov_session_id,
+                options={"memory_policy": memory_policy} if memory_policy else None,
             )
 
     async def append(self, ov_session_id: str, messages: List[Dict[str, Any]]) -> int:

openviking/session/train/components/session_commit.py

@@ -134,7 +134,7 @@ async def _commit_one(
             stage = "create_session"
             await self.client.create_session(
                 session_id=session_id,
-                memory_policy=_training_commit_memory_policy(),
+                options={"memory_policy": _training_commit_memory_policy()},
             )
             stage = "batch_add_messages"
             await self._batch_add_messages(session_id, messages)

tests/ingest/test_replay.py

@@ -22,8 +22,8 @@ async def get_session(self, sid, *, auto_create=False):
             raise NotFoundError(sid, "session")
         return {"session_id": sid, "pending_tokens": 0, "message_count": 0}
 
-    async def create_session(self, session_id=None, memory_policy=None):
-        self.created.append(session_id)
+    async def create_session(self, session_id=None, options=None):
+        self.created.append((session_id, options))
         self.existing.add(session_id)
         return {"session_id": session_id}
 
@@ -40,9 +40,12 @@ async def test_ensure_session_get_or_create():
     sdk = _FakeSDK()
     client = ConversationReplayClient(sdk)
     await client.ensure_session("s1")  # not present -> create
-    assert sdk.created == ["s1"]
+    assert sdk.created == [("s1", None)]
     await client.ensure_session("s1")  # now present -> no second create
-    assert sdk.created == ["s1"]
+    assert sdk.created == [("s1", None)]
+    # a memory policy travels inside CreateSessionOptions, not as a keyword
+    await client.ensure_session("s2", {"working_memory": {"enabled": False}})
+    assert sdk.created[-1] == ("s2", {"memory_policy": {"working_memory": {"enabled": False}}})
 
 
 async def test_append_chunks_at_100():

tests/session/train/test_train_framework.py

@@ -1206,8 +1206,8 @@ def __init__(self):
         self.committed_sessions = []
         self.task_poll_counts = {}
 
-    async def create_session(self, *, session_id, memory_policy=None):
-        self.created_sessions.append((session_id, memory_policy))
+    async def create_session(self, session_id=None, options=None):
+        self.created_sessions.append((session_id, options))
 
     async def batch_add_messages(self, session_id, messages):
         self.messages.setdefault(session_id, []).extend(messages)
@@ -1257,8 +1257,10 @@ async def test_session_commit_policy_trainer_records_commit_trace_id():
         (
             commit_result["session_id"],
             {
-                "memory_types": ["cases", "trajectories", "experiences"],
-                "working_memory": {"enabled": False},
+                "memory_policy": {
+                    "memory_types": ["cases", "trajectories", "experiences"],
+                    "working_memory": {"enabled": False},
+                }
             },
         )
     ]