Skip to content

Commit 5c2e441

Browse files
authored
fix: remove codex config envs from code sandbox (#915)
1 parent 89663c8 commit 5c2e441

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

tests/cli/test_frontend_skill_creator.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -389,6 +389,8 @@ def test_model_credential_is_bound_directly_to_tool(
389389
assert envs["MODEL_AGENT_NAME"] == envs["CODEX_MODEL"]
390390
assert envs["MODEL_AGENT_BASE_URL"] == expected_base_url
391391
assert envs["AGENTKIT_SANDBOX_MODEL_PROVIDER"] == expected_model_provider
392+
assert "CODEX_CONFIG_TOML" not in envs
393+
assert "CODEX_MODEL_CATALOG_JSON" not in envs
392394

393395

394396
def test_code_env_credential_accepts_a_provider_specific_default_model() -> None:
@@ -485,6 +487,7 @@ def delete_session(self, _request: object) -> None:
485487
assert {"CODEX_API_KEY", "OPENCODE_API_KEY", "ANTHROPIC_AUTH_TOKEN"}.isdisjoint(
486488
envs
487489
)
490+
assert {"CODEX_CONFIG_TOML", "CODEX_MODEL_CATALOG_JSON"}.isdisjoint(envs)
488491

489492

490493
def test_tool_rejects_untrusted_model_base_url() -> None:

veadk/cli/frontend_skill_creator.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -770,7 +770,7 @@ def ensure_skill_creator_model_credential(
770770
model_base_url=model_base_url,
771771
model_provider_was_provided=True,
772772
model_base_url_was_provided=True,
773-
include_codex_config=True,
773+
include_codex_config=False,
774774
disable_websearch_apikey=True,
775775
)
776776
if not session_envs:
@@ -1118,7 +1118,7 @@ def _create_candidate(
11181118
model_base_url=model_base_url,
11191119
model_provider_was_provided=True,
11201120
model_base_url_was_provided=True,
1121-
include_codex_config=True,
1121+
include_codex_config=False,
11221122
disable_websearch_apikey=True,
11231123
)
11241124
safe_session_envs = [

0 commit comments

Comments
 (0)