Skip to content

Commit 41df4ca

Browse files
committed
revision based on review comments
1 parent 5a8d313 commit 41df4ca

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

docs/ascend_tutorial/ascend_profiling_en.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Data collection based on FSDP or MindSpeed(Megatron) on Ascend devices(en)
1+
Performance data collection based on FSDP or MindSpeed(Megatron) on Ascend devices(en)
22
==========================================================================================
33

44
Last updated: 08/14/2025.

docs/ascend_tutorial/ascend_profiling_zh.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
Data collection based on FSDP or MindSpeed(Megatron) on Ascend devices(zh)
1+
Performance data collection based on FSDP or MindSpeed(Megatron) on Ascend devices(zh)
22
====================================
33

4-
在昇腾设备上基于FSDP或MindSpeed(Megatron)后端进行数据采集
4+
在昇腾设备上基于FSDP或MindSpeed(Megatron)后端进行性能数据采集
55

66
Last updated: 08/14/2025.
77

verl/workers/fsdp_workers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1506,7 +1506,7 @@ def compute_values(self, data: DataProto):
15061506
return output
15071507

15081508
@register(dispatch_mode=make_nd_compute_dataproto_dispatch_fn(mesh_name="critic"))
1509-
@DistProfiler.annotate(color="pink", role="update_critic")
1509+
@DistProfiler.annotate(color="pink", role="critic_update")
15101510
def update_critic(self, data: DataProto):
15111511
if self._is_offload_param:
15121512
load_fsdp_model_to_gpu(self.critic_module)

verl/workers/megatron_workers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1224,7 +1224,7 @@ def compute_values(self, data: DataProto):
12241224
return output
12251225

12261226
@register(dispatch_mode=make_nd_compute_dataproto_dispatch_fn(mesh_name="critic"))
1227-
@DistProfiler.annotate(color="pink", role="update_critic")
1227+
@DistProfiler.annotate(color="pink", role="critic_update")
12281228
def update_critic(self, data: DataProto):
12291229
data = data.to(get_device_id())
12301230

0 commit comments

Comments
 (0)