Skip to content

Commit ade6862

Browse files
authored
[ci] fix: Fix error in ascend dockerfile (#4265)
### What does this PR do? Fix error in ascend dockerfile ### Checklist Before Starting - [ ] Search for similar PRs. Paste at least one query link here: ... - [ ] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test Not related. ### API and Usage Example Not related. ### Design & Code Changes Not related. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [ ] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [ ] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [ ] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). - [ ] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [ ] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
1 parent f231b97 commit ade6862

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

docker/ascend/Dockerfile.ascend_8.3.rc1_a2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ RUN ARCH=$(uname -m) && \
4343
pip install -e MindSpeed && \
4444
echo "export PYTHONPATH=\$PYTHONPATH:/Megatron-LM" >> ~/.bashrc && \
4545
# Remove existing triton or triton-ascend installed by some third-party packages
46-
pip uninstall -y triton triton-ascend \
46+
pip uninstall -y triton triton-ascend && \
4747
# Clear extra files
4848
rm -rf /tmp/* /var/tmp/* && \
4949
pip cache purge

docker/ascend/Dockerfile.ascend_8.3.rc1_a3

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ RUN ARCH=$(uname -m) && \
4343
pip install -e MindSpeed && \
4444
echo "export PYTHONPATH=\$PYTHONPATH:/Megatron-LM" >> ~/.bashrc && \
4545
# Remove existing triton or triton-ascend installed by some third-party packages
46-
pip uninstall -y triton triton-ascend \
46+
pip uninstall -y triton triton-ascend && \
4747
# Clear extra files
4848
rm -rf /tmp/* /var/tmp/* && \
4949
pip cache purge

0 commit comments

Comments
 (0)