Merge pull request #200 from volllly/fix/link-file-not-existing

Fix creating empty symlinks if the source file does not exist

Author: volllly

CHANGELOG.md

@@ -6,6 +6,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.9.3] - 2023-02-12
+
+### Fixed
+
+- Issue where rotz would create empty symlinks if the source file does not exist
+
 ## [0.9.2] - 2023-01-18
 
 ### Fixed
@@ -192,7 +198,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Dotfile linking
 - Error handling
 
-[Unreleased]: https://github.com/volllly/rotz/compare/v0.9.2...HEAD
+[Unreleased]: https://github.com/volllly/rotz/compare/v0.9.3...HEAD
+[0.9.3]: https://github.com/volllly/rotz/releases/tag/v0.9.3
 [0.9.2]: https://github.com/volllly/rotz/releases/tag/v0.9.2
 [0.9.1]: https://github.com/volllly/rotz/releases/tag/v0.9.1
 [0.9.0]: https://github.com/volllly/rotz/releases/tag/v0.9.0

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "rotz"
-version = "0.9.2"
+version = "0.9.3"
 edition = "2021"
 authors = ["Paul Volavsek <paul.volavsek@gmail.com>"]
 license = "MIT"

Cargo.toml

@@ -36,6 +36,10 @@ enum Error {
   #[error("The file \"{0}\" already exists")]
   #[diagnostic(code(link::already_exists), help("Try using the --force flag"))]
   AlreadyExists(PathBuf),
+
+  #[error("The link source file \"{0}\" does not exist exists")]
+  #[diagnostic(code(link::does_not_exist), help("Maybe you have a typo in the filename?"))]
+  LinkSourceDoesNotExist(PathBuf),
 }
 
 pub(crate) struct Link<'a> {
@@ -161,6 +165,10 @@ impl<'a> Command for Link<'a> {
 
 #[cfg_attr(feature = "profiling", instrument)]
 fn create_link(from: &Path, to: &Path, link_type: &LinkType, force: bool, linked: Option<&HashMap<PathBuf, PathBuf>>) -> std::result::Result<(), Error> {
+  if !from.exists() {
+    return Error::LinkSourceDoesNotExist(from.to_path_buf()).pipe(Err);
+  }
+
   let create: fn(&Path, &Path) -> std::result::Result<(), std::io::Error> = if link_type.is_symbolic() { symlink } else { hardlink };
 
   match create(from, to) {