Skip to content

Commit 805a0e1

Browse files
committed
fix: Make abrousseau001@ Homebrew contribution comply with Error Prone rules enforced in this project
See https://errorprone.info/bugpattern/UnrecognisedJavadocTag (which, very strangely, I cannot reproduce locally; only happens on CI?!), and https://errorprone.info/bugpattern/StringCaseLocaleUsage (and google/error-prone#4951).
1 parent 0322dc5 commit 805a0e1

File tree

1 file changed

+3
-2
lines changed
  • mariaDB4j-core/src/main/java/ch/vorburger/mariadb4j

1 file changed

+3
-2
lines changed

mariaDB4j-core/src/main/java/ch/vorburger/mariadb4j/Util.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import java.io.IOException;
2424
import java.net.URL;
2525
import java.nio.charset.StandardCharsets;
26+
import java.util.Locale;
2627
import java.util.concurrent.TimeUnit;
2728
import org.apache.commons.io.FileUtils;
2829
import org.apache.commons.lang3.SystemUtils;
@@ -164,7 +165,7 @@ public static int extractFromClasspathToFile(String packagePath, File toDir) thr
164165
/**
165166
* Method to check for the MariaDB installation on the system and then install if not installed.
166167
*
167-
* @return @{@link boolean} representing whether MariaDB has been installed on the system
168+
* @return whether MariaDB has been installed on the system
168169
*/
169170
public static boolean installMariaDbFromHomebrew() {
170171
boolean mariadbIsInstalled = false;
@@ -191,7 +192,7 @@ public static boolean installMariaDbFromHomebrew() {
191192

192193
String checkInstallOutput = new String(brewInstall.getInputStream().readAllBytes(), StandardCharsets.UTF_8);
193194

194-
if (checkInstallOutput.toLowerCase().contains("error")) {
195+
if (checkInstallOutput.toLowerCase(Locale.ROOT).contains("error")) {
195196
throw new IllegalStateException("Failed to install mariadb with Homebrew - see " + checkInstallOutput);
196197
}
197198

0 commit comments

Comments
 (0)