File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change 7474 env :
7575 RUSTFLAGS : " -C target-cpu=native"
7676 run : |
77- cargo build --bin ${{ matrix.benchmark.id }} --profile release_debug ${{ matrix.benchmark.build_args }} --features unstable_encodings
77+ cargo build --workspace -- bin ${{ matrix.benchmark.id }} --profile release_debug ${{ matrix.benchmark.build_args }} --features unstable_encodings
7878
7979 - name : Setup Polar Signals
8080 uses : polarsignals/gh-actions-ps-profiling@68ae857e375a826606352016e5b90f01a2a7ff7a # v0.8.1
Original file line number Diff line number Diff line change @@ -129,7 +129,7 @@ jobs:
129129 - uses : ./.github/actions/setup-prebuild
130130 - name : Docs
131131 run : |
132- RUSTDOCFLAGS="-D warnings" cargo doc --profile ci --no-deps
132+ RUSTDOCFLAGS="-D warnings" cargo doc --workspace -- profile ci --no-deps
133133 # nextest doesn't support doc tests, so we run it here
134134 cargo test --profile ci --doc --workspace --all-features --exclude vortex-cxx --exclude vortex-jni --exclude vortex-ffi --exclude xtask --no-fail-fast
135135
@@ -220,19 +220,19 @@ jobs:
220220 - name : Rustc check
221221 id : check
222222 continue-on-error : true
223- run : RUSTFLAGS="-D warnings" cargo check --profile ci --locked --all-features --all-targets
223+ run : RUSTFLAGS="-D warnings" cargo check --workspace -- profile ci --locked --all-features --all-targets
224224 - name : Rustc check (release)
225225 id : check-release
226226 continue-on-error : true
227- run : RUSTFLAGS="-D warnings" cargo check --locked --all-features --all-targets --release
227+ run : RUSTFLAGS="-D warnings" cargo check --workspace -- locked --all-features --all-targets --release
228228 - name : Rust Lint - Clippy All Features
229229 id : clippy-all
230230 continue-on-error : true
231- run : cargo clippy --profile ci --locked --all-features --all-targets -- -D warnings
231+ run : cargo clippy --workspace -- profile ci --locked --all-features --all-targets -- -D warnings
232232 - name : Rust Lint - Clippy Default Features
233233 id : clippy-default
234234 continue-on-error : true
235- run : cargo clippy --profile ci --locked --all-targets -- -D warnings
235+ run : cargo clippy --workspace -- profile ci --locked --all-targets -- -D warnings
236236 - name : Check lint results
237237 if : always()
238238 uses : actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9
Original file line number Diff line number Diff line change @@ -349,7 +349,7 @@ jobs:
349349 if [ "${{ inputs.mode }}" != "pr" ]; then
350350 packages="$packages --bin lance-bench"
351351 fi
352- cargo build $packages --profile release_debug --features unstable_encodings
352+ cargo build --workspace $packages --profile release_debug --features unstable_encodings
353353
354354 - name : Generate data
355355 shell : bash
Original file line number Diff line number Diff line change @@ -45,6 +45,11 @@ broad refactor:
4545cargo build --workspace
4646```
4747
48+ cargo build, cargo clippy, cargo nextest run without -p or --workspace don't
49+ cover crates that are not in "default-members" in Cargo.toml. If you change
50+ crates that are not in "default-members", build and test them using "-p" or
51+ "--workspace".
52+
4853## Testing
4954
5055Run tests for the crate or binding you touched before broader checks:
Original file line number Diff line number Diff line change @@ -70,6 +70,65 @@ members = [
7070 " vortex-geo" ,
7171]
7272exclude = [" java/testfiles" , " wasm-test" ]
73+
74+ # Benchmark harnesses and fuzzing account for 40% of a cold workspace build
75+ # and they aren't needed for ordinary builds.
76+ default-members = [
77+ " vortex-array-macros" ,
78+ " vortex-error" ,
79+ " vortex-buffer" ,
80+ " vortex-mask" ,
81+ " vortex-utils" ,
82+ " vortex-session" ,
83+ " vortex-flatbuffers" ,
84+ " vortex-metrics" ,
85+ " vortex-io" ,
86+ " vortex-proto" ,
87+ " vortex-array" ,
88+ " vortex-row" ,
89+ " vortex-tensor" ,
90+ " vortex-json" ,
91+ " vortex-compressor" ,
92+ " vortex-btrblocks" ,
93+ " vortex-layout" ,
94+ " vortex-scan" ,
95+ " vortex-file" ,
96+ " vortex-ipc" ,
97+ " vortex" ,
98+ " vortex-datafusion" ,
99+ " vortex-duckdb" ,
100+ " vortex-cuda" ,
101+ " vortex-cuda/cub" ,
102+ " vortex-cuda/ffi" ,
103+ " vortex-cuda/gpu-scan-cli" ,
104+ " vortex-cuda/macros" ,
105+ " vortex-cuda/nvcomp" ,
106+ " vortex-cxx" ,
107+ " vortex-ffi" ,
108+ " vortex-jni" ,
109+ " vortex-python" ,
110+ " vortex-tui" ,
111+ " vortex-web/crate" ,
112+ " vortex-sqllogictest" ,
113+ " vortex-test/compat-gen" ,
114+ " vortex-test/e2e-cuda" ,
115+ " xtask" ,
116+ " encodings/fastlanes" ,
117+ " encodings/decimal-byte-parts" ,
118+ " encodings/runend" ,
119+ " encodings/sequence" ,
120+ " encodings/alp" ,
121+ " encodings/datetime-parts" ,
122+ " encodings/fsst" ,
123+ " encodings/pco" ,
124+ " encodings/sparse" ,
125+ " encodings/zigzag" ,
126+ " encodings/zstd" ,
127+ " encodings/bytebool" ,
128+ " encodings/parquet-variant" ,
129+ " encodings/experimental/onpair" ,
130+ " vortex-geo" ,
131+ ]
73132resolver = " 2"
74133
75134[workspace .package ]
You can’t perform that action at this time.
0 commit comments