Skip to content

Fix dtype mismatch in Filter::take logic#8073

Open
robert3005 wants to merge 1 commit into
developfrom
rk/fuzzerror
Open

Fix dtype mismatch in Filter::take logic#8073
robert3005 wants to merge 1 commit into
developfrom
rk/fuzzerror

Conversation

@robert3005
Copy link
Copy Markdown
Contributor

This got caught by the fuzzer and was missed in the original pr

Signed-off-by: Robert Kruszewski <github@robertk.io>
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 22, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 1248 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime cuda/bitpacked_u8/unpack/3bw[100M] 353 µs 299.3 µs +17.94%
Simulation chunked_varbinview_canonical_into[(100, 100)] 307.9 µs 273.2 µs +12.67%
Simulation chunked_varbinview_opt_canonical_into[(1000, 10)] 187.5 µs 225.4 µs -16.79%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/fuzzerror (4370757) with develop (495f30e)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant