Skip to content

Commit 0250e53

Browse files
committed
add env FIFTYONE_APP_DEPLOYMENT_CHARACTERISTICS for teams-app
1 parent afc8516 commit 0250e53

8 files changed

Lines changed: 50 additions & 0 deletions

File tree

docker/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -825,6 +825,7 @@ If containers show unhealthy states (e.g., `Restarting`, `Exited`):
825825
| `FIFTYONE_APP_THEME` | The default theme configuration for your FiftyOne Enterprise application as described [in our documentation](https://docs.voxel51.com/user_guide/config.html#configuring-the-app) | No |
826826
| `FIFTYONE_APP_DEFAULT_QUERY_PERFORMANCE` | Controls whether Query Performance mode is enabled by default for every dataset for the application. Set to false to set default mode to off. | No |
827827
| `FIFTYONE_APP_ENABLE_QUERY_PERFORMANCE` | Controls whether Query Performance mode is enabled for the application. Set to false to disable Query Performance mode for entire application. | No |
828+
| `FIFTYONE_APP_DEPLOYMENT_CHARACTERISTICS` | Deployment characteristics for the `teams-app` | No |
828829
| `FIFTYONE_API_URI` | The URI to be displayed in the `Install FiftyOne` Modal and `API Keys` configuration screens | No |
829830
| `FIFTYONE_AUTH_SECRET` | The secret used for services to authenticate with `teams-cas`; also used to login to the SuperAdmin UI | Yes |
830831
| `FIFTYONE_DATABASE_NAME` | The MongoDB Database that `fiftyone-app`, `teams-api`, and `teams-app` use for FiftyOne Enterprise dataset metadata; the default is `fiftyone` | Yes |

docker/common-services.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ services:
7575
NODE_ENV: production
7676
RECOIL_DUPLICATE_ATOM_KEY_CHECKING_ENABLED: false
7777
FIFTYONE_APP_ANONYMOUS_ANALYTICS_ENABLED: ${FIFTYONE_APP_ANONYMOUS_ANALYTICS_ENABLED:-true}
78+
FIFTYONE_APP_DEPLOYMENT_CHARACTERISTICS: docker
7879
# If you are routing through a proxy server you will want to set
7980
# HTTP_PROXY_URL, HTTPS_PROXY_URL, and NO_PROXY_LIST in your .env
8081
# then add the following environment variables to your

helm/fiftyone-teams-app/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1038,6 +1038,7 @@ If pods show unhealthy states (e.g., `0/1`, `CrashLoopBackOff`, `Pending`):
10381038
| teamsAppSettings.env.APP_USE_HTTPS | bool | `true` | Controls the protocol of the `teams-app`. Configure your ingress to match. When `true`, uses the https protocol. When `false`, uses the http protocol. |
10391039
| teamsAppSettings.env.FIFTYONE_APP_ALLOW_MEDIA_EXPORT | bool | `true` | When `false`, disables media export options |
10401040
| teamsAppSettings.env.FIFTYONE_APP_ANONYMOUS_ANALYTICS_ENABLED | bool | `true` | Controls whether anonymous analytics are captured for the application. Set to false to opt-out of anonymous analytics. |
1041+
| teamsAppSettings.env.FIFTYONE_APP_DEPLOYMENT_CHARACTERISTICS | string | `"kubernetes"` | Deployment characteristics for the `teams-app`. `kubernetes`: Indicates the app is running in a Kubernetes environment. `docker`: Indicates the app is running in a Docker environment. `kubernetes,managed`: Indicates the app is running in a managed Kubernetes environment |
10411042
| teamsAppSettings.env.FIFTYONE_APP_TEAMS_SDK_RECOMMENDED_VERSION | string | `"2.17.1"` | The recommended fiftyone SDK version that will be displayed in the install modal (i.e. `pip install ... fiftyone==0.11.0`). |
10421043
| teamsAppSettings.env.FIFTYONE_APP_THEME | string | `"dark"` | The default theme configuration. `dark`: Theme will be dark when user visits for the first time. `light`: Theme will be light theme when user visits for the first time. `always-dark`: Sets dark theme on each refresh (overrides user theme changes in the app). `always-light`: Sets light theme on each refresh (overrides user theme changes in the app). |
10431044
| teamsAppSettings.env.RECOIL_DUPLICATE_ATOM_KEY_CHECKING_ENABLED | bool | `false` | Disable duplicate atom/selector key checking that generated false-positive errors. [Reference][recoil-env]. |

helm/fiftyone-teams-app/values.schema.json

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3672,6 +3672,13 @@
36723672
"boolean"
36733673
]
36743674
},
3675+
"FIFTYONE_APP_DEPLOYMENT_CHARACTERISTICS": {
3676+
"default": "kubernetes",
3677+
"description": "Deployment characteristics for the `teams-app`.\n`kubernetes`: Indicates the app is running in a Kubernetes environment.\n`docker`: Indicates the app is running in a Docker environment.\n`kubernetes,managed`: Indicates the app is running in a managed Kubernetes environment",
3678+
"required": [],
3679+
"title": "FIFTYONE_APP_DEPLOYMENT_CHARACTERISTICS",
3680+
"type": "string"
3681+
},
36753682
"FIFTYONE_APP_TEAMS_SDK_RECOMMENDED_VERSION": {
36763683
"default": "2.17.1",
36773684
"description": "The recommended fiftyone SDK version that will be displayed in the\ninstall modal (i.e. `pip install ... fiftyone==0.11.0`).",

helm/fiftyone-teams-app/values.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1419,6 +1419,11 @@ teamsAppSettings:
14191419
# -- Controls whether anonymous analytics are captured for the
14201420
# application. Set to false to opt-out of anonymous analytics.
14211421
FIFTYONE_APP_ANONYMOUS_ANALYTICS_ENABLED: true
1422+
# -- Deployment characteristics for the `teams-app`.
1423+
# `kubernetes`: Indicates the app is running in a Kubernetes environment.
1424+
# `docker`: Indicates the app is running in a Docker environment.
1425+
# `kubernetes,managed`: Indicates the app is running in a managed Kubernetes environment
1426+
FIFTYONE_APP_DEPLOYMENT_CHARACTERISTICS: 'kubernetes'
14221427

14231428
# -- Secret variables to be passed to the `teams-app` containers.
14241429
secretEnv: {}

tests/unit/compose/docker-compose-internal-auth_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -290,6 +290,7 @@ func (s *commonServicesInternalAuthDockerComposeTest) TestServiceEnvironment() {
290290
"NODE_ENV=production",
291291
"RECOIL_DUPLICATE_ATOM_KEY_CHECKING_ENABLED=false",
292292
"FIFTYONE_APP_ANONYMOUS_ANALYTICS_ENABLED=true",
293+
"FIFTYONE_APP_DEPLOYMENT_CHARACTERISTICS=docker",
293294
},
294295
},
295296
{
@@ -374,6 +375,7 @@ func (s *commonServicesInternalAuthDockerComposeTest) TestServiceEnvironment() {
374375
"NODE_ENV=production",
375376
"RECOIL_DUPLICATE_ATOM_KEY_CHECKING_ENABLED=false",
376377
"FIFTYONE_APP_ANONYMOUS_ANALYTICS_ENABLED=true",
378+
"FIFTYONE_APP_DEPLOYMENT_CHARACTERISTICS=docker",
377379
},
378380
},
379381
{
@@ -458,6 +460,7 @@ func (s *commonServicesInternalAuthDockerComposeTest) TestServiceEnvironment() {
458460
"RECOIL_DUPLICATE_ATOM_KEY_CHECKING_ENABLED=false",
459461
"FIFTYONE_TEAMS_PLUGIN_URL=http://teams-plugins:5151",
460462
"FIFTYONE_APP_ANONYMOUS_ANALYTICS_ENABLED=true",
463+
"FIFTYONE_APP_DEPLOYMENT_CHARACTERISTICS=docker",
461464
},
462465
},
463466
{

tests/unit/compose/docker-compose-legacy-auth_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -290,6 +290,7 @@ func (s *commonServicesLegacyAuthDockerComposeTest) TestServiceEnvironment() {
290290
"NODE_ENV=production",
291291
"RECOIL_DUPLICATE_ATOM_KEY_CHECKING_ENABLED=false",
292292
"FIFTYONE_APP_ANONYMOUS_ANALYTICS_ENABLED=true",
293+
"FIFTYONE_APP_DEPLOYMENT_CHARACTERISTICS=docker",
293294
},
294295
},
295296
{
@@ -371,6 +372,7 @@ func (s *commonServicesLegacyAuthDockerComposeTest) TestServiceEnvironment() {
371372
"NODE_ENV=production",
372373
"RECOIL_DUPLICATE_ATOM_KEY_CHECKING_ENABLED=false",
373374
"FIFTYONE_APP_ANONYMOUS_ANALYTICS_ENABLED=true",
375+
"FIFTYONE_APP_DEPLOYMENT_CHARACTERISTICS=docker",
374376
},
375377
},
376378
{
@@ -454,6 +456,7 @@ func (s *commonServicesLegacyAuthDockerComposeTest) TestServiceEnvironment() {
454456
"NODE_ENV=production",
455457
"RECOIL_DUPLICATE_ATOM_KEY_CHECKING_ENABLED=false",
456458
"FIFTYONE_APP_ANONYMOUS_ANALYTICS_ENABLED=true",
459+
"FIFTYONE_APP_DEPLOYMENT_CHARACTERISTICS=docker",
457460
},
458461
},
459462
{
@@ -537,6 +540,7 @@ func (s *commonServicesLegacyAuthDockerComposeTest) TestServiceEnvironment() {
537540
"RECOIL_DUPLICATE_ATOM_KEY_CHECKING_ENABLED=false",
538541
"FIFTYONE_TEAMS_PLUGIN_URL=http://teams-plugins:5151",
539542
"FIFTYONE_APP_ANONYMOUS_ANALYTICS_ENABLED=true",
543+
"FIFTYONE_APP_DEPLOYMENT_CHARACTERISTICS=docker",
540544
},
541545
},
542546
{

tests/unit/helm/teams-app-deployment_test.go

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -492,6 +492,10 @@ func (s *deploymentTeamsAppTemplateTest) TestContainerEnv() {
492492
"name": "FIFTYONE_APP_ANONYMOUS_ANALYTICS_ENABLED",
493493
"value": "true"
494494
},
495+
{
496+
"name": "FIFTYONE_APP_DEPLOYMENT_CHARACTERISTICS",
497+
"value": "kubernetes"
498+
},
495499
{
496500
"name": "FIFTYONE_APP_TEAMS_SDK_RECOMMENDED_VERSION",
497501
"value": "%s"
@@ -574,6 +578,10 @@ func (s *deploymentTeamsAppTemplateTest) TestContainerEnv() {
574578
"name": "FIFTYONE_APP_ANONYMOUS_ANALYTICS_ENABLED",
575579
"value": "true"
576580
},
581+
{
582+
"name": "FIFTYONE_APP_DEPLOYMENT_CHARACTERISTICS",
583+
"value": "kubernetes"
584+
},
577585
{
578586
"name": "FIFTYONE_APP_TEAMS_SDK_RECOMMENDED_VERSION",
579587
"value": "%s"
@@ -669,6 +677,10 @@ func (s *deploymentTeamsAppTemplateTest) TestContainerEnv() {
669677
"name": "FIFTYONE_APP_ANONYMOUS_ANALYTICS_ENABLED",
670678
"value": "true"
671679
},
680+
{
681+
"name": "FIFTYONE_APP_DEPLOYMENT_CHARACTERISTICS",
682+
"value": "kubernetes"
683+
},
672684
{
673685
"name": "FIFTYONE_APP_TEAMS_SDK_RECOMMENDED_VERSION",
674686
"value": "%s"
@@ -750,6 +762,10 @@ func (s *deploymentTeamsAppTemplateTest) TestContainerEnv() {
750762
"name": "FIFTYONE_APP_ANONYMOUS_ANALYTICS_ENABLED",
751763
"value": "true"
752764
},
765+
{
766+
"name": "FIFTYONE_APP_DEPLOYMENT_CHARACTERISTICS",
767+
"value": "kubernetes"
768+
},
753769
{
754770
"name": "FIFTYONE_APP_TEAMS_SDK_RECOMMENDED_VERSION",
755771
"value": "%s"
@@ -830,6 +846,10 @@ func (s *deploymentTeamsAppTemplateTest) TestContainerEnv() {
830846
"name": "FIFTYONE_APP_ANONYMOUS_ANALYTICS_ENABLED",
831847
"value": "true"
832848
},
849+
{
850+
"name": "FIFTYONE_APP_DEPLOYMENT_CHARACTERISTICS",
851+
"value": "kubernetes"
852+
},
833853
{
834854
"name": "FIFTYONE_APP_TEAMS_SDK_RECOMMENDED_VERSION",
835855
"value": "%s"
@@ -910,6 +930,10 @@ func (s *deploymentTeamsAppTemplateTest) TestContainerEnv() {
910930
"name": "FIFTYONE_APP_ANONYMOUS_ANALYTICS_ENABLED",
911931
"value": "true"
912932
},
933+
{
934+
"name": "FIFTYONE_APP_DEPLOYMENT_CHARACTERISTICS",
935+
"value": "kubernetes"
936+
},
913937
{
914938
"name": "FIFTYONE_APP_TEAMS_SDK_RECOMMENDED_VERSION",
915939
"value": "%s"
@@ -990,6 +1014,10 @@ func (s *deploymentTeamsAppTemplateTest) TestContainerEnv() {
9901014
"name": "FIFTYONE_APP_ANONYMOUS_ANALYTICS_ENABLED",
9911015
"value": "true"
9921016
},
1017+
{
1018+
"name": "FIFTYONE_APP_DEPLOYMENT_CHARACTERISTICS",
1019+
"value": "kubernetes"
1020+
},
9931021
{
9941022
"name": "FIFTYONE_APP_TEAMS_SDK_RECOMMENDED_VERSION",
9951023
"value": "%s"

0 commit comments

Comments
 (0)