Skip to content

Commit 1a7034b

Browse files
authored
chore(utils): AS-788 speed up docker image checking (#406)
1 parent dbb0126 commit 1a7034b

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

utils/validate-docker-pulls.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ VALUES_YAML="${GIT_ROOT}/helm/fiftyone-teams-app/values.yaml"
3232
print_usage() {
3333
local package
3434
package=$(basename "$0")
35-
echo "$package - Validate docker pulls for all default images."
35+
echo "$package - Validate docker images exist for all default images."
3636
echo " "
3737
echo "$package [options]"
3838
echo " "
@@ -86,7 +86,7 @@ check_requirements() {
8686
docker_pull() {
8787
local image="$1"
8888

89-
if ! docker pull "${image}"; then
89+
if ! docker manifest inspect "${image}"; then
9090
return 1
9191
fi
9292

@@ -147,10 +147,10 @@ set -e
147147

148148
for idx in "${!rcs[@]}"; do
149149
if [[ ${rcs[$idx]} -ne 0 ]]; then
150-
log_error "Could not pull ${expected_images_with_tag[$idx]}!"
150+
log_error "Could not validate ${expected_images_with_tag[$idx]}!"
151151
exit_code=1
152152
else
153-
log_info "Pulled ${expected_images_with_tag[$idx]} successfully."
153+
log_info "Validated ${expected_images_with_tag[$idx]} successfully."
154154
fi
155155
done
156156

0 commit comments

Comments
 (0)