feat(helm): support pre-provisioned PVC for telemetry Redis

Adds telemetry.redis.persistence.existingClaim so operators on clusters
without a dynamic PV provisioner (or wanting to reuse a volume across
releases) can hand the chart a pre-created PVC instead of relying on
chart-managed provisioning. When set, the chart skips its PVC render and
the Deployment mounts the named claim; persistence.enabled=false still
wins and yields an emptyDir.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: mo-getter

helm/fiftyone-teams-app/README.md

@@ -1092,6 +1092,7 @@ If pods show unhealthy states (e.g., `0/1`, `CrashLoopBackOff`, `Pending`):
 | telemetry.redis.maxmemory | string | `"400mb"` | `--maxmemory` flag passed to `redis-server`. |
 | telemetry.redis.maxmemoryPolicy | string | `"allkeys-lru"` | `--maxmemory-policy` flag passed to `redis-server`. |
 | telemetry.redis.persistence.enabled | bool | `true` | Controls whether a `PersistentVolumeClaim` is created for the bundled telemetry Redis. When `false`, Redis runs with an `emptyDir` volume and state is lost on pod restart — fine for dev clusters without a dynamic PV provisioner, not for production. |
+| telemetry.redis.persistence.existingClaim | string | `""` | Name of an existing `PersistentVolumeClaim` (in `namespace.name`) to bind the telemetry Redis to. When set, the chart will NOT create a `PersistentVolumeClaim` and the `size` / `storageClass` fields above are ignored — you are responsible for provisioning the claim out of band. Use this on clusters without a dynamic PV provisioner, or to reuse an existing volume across releases. Has no effect when `persistence.enabled` is `false`. |
 | telemetry.redis.persistence.size | string | `"1Gi"` | Storage size for the telemetry Redis `PersistentVolumeClaim`. |
 | telemetry.redis.persistence.storageClass | string | `""` | `StorageClass` name for the telemetry Redis `PersistentVolumeClaim`. Leave unset to use the cluster's default `StorageClass`. |
 | telemetry.redis.podSecurityContext | object | `{"fsGroup":999,"runAsGroup":999,"runAsNonRoot":true,"runAsUser":999}` | Pod-level security attributes for the telemetry Redis. Defaults to a non-root UID/GID matching the `redis` user in the upstream `redis:7-alpine` image (999). `fsGroup` ensures the mounted `/data` volume is group-writable. [Reference][security-context]. |

helm/fiftyone-teams-app/templates/telemetry-redis.yaml

@@ -1,5 +1,5 @@
 {{- if and .Values.telemetry.enabled (not .Values.telemetry.redis.external.url) }}
-{{- if .Values.telemetry.redis.persistence.enabled }}
+{{- if and .Values.telemetry.redis.persistence.enabled (not .Values.telemetry.redis.persistence.existingClaim) }}
 apiVersion: v1
 kind: PersistentVolumeClaim
 metadata:
@@ -72,7 +72,7 @@ spec:
         - name: redis-data
           {{- if .Values.telemetry.redis.persistence.enabled }}
           persistentVolumeClaim:
-            claimName: {{ include "telemetry.redis.name" . }}-data
+            claimName: {{ .Values.telemetry.redis.persistence.existingClaim | default (printf "%s-data" (include "telemetry.redis.name" .)) }}
           {{- else }}
           emptyDir: {}
           {{- end }}

helm/fiftyone-teams-app/values.schema.json

@@ -4017,6 +4017,12 @@
                   "title": "enabled",
                   "type": "boolean"
                 },
+                "existingClaim": {
+                  "default": "",
+                  "description": "Name of an existing `PersistentVolumeClaim` (in `namespace.name`) to\nbind the telemetry Redis to. When set, the chart will NOT create a\n`PersistentVolumeClaim` and the `size` / `storageClass` fields above\nare ignored — you are responsible for provisioning the claim out of\nband. Use this on clusters without a dynamic PV provisioner, or to\nreuse an existing volume across releases. Has no effect when\n`persistence.enabled` is `false`.",
+                  "title": "existingClaim",
+                  "type": "string"
+                },
                 "size": {
                   "default": "1Gi",
                   "description": "Storage size for the telemetry Redis `PersistentVolumeClaim`.",

helm/fiftyone-teams-app/values.yaml

@@ -1632,6 +1632,14 @@ telemetry:
       # -- `StorageClass` name for the telemetry Redis `PersistentVolumeClaim`.
       # Leave unset to use the cluster's default `StorageClass`.
       storageClass: ""
+      # -- Name of an existing `PersistentVolumeClaim` (in `namespace.name`) to
+      # bind the telemetry Redis to. When set, the chart will NOT create a
+      # `PersistentVolumeClaim` and the `size` / `storageClass` fields above
+      # are ignored — you are responsible for provisioning the claim out of
+      # band. Use this on clusters without a dynamic PV provisioner, or to
+      # reuse an existing volume across releases. Has no effect when
+      # `persistence.enabled` is `false`.
+      existingClaim: ""
     # -- `--maxmemory` flag passed to `redis-server`.
     maxmemory: 400mb
     # -- `--maxmemory-policy` flag passed to `redis-server`.

tests/unit/helm/telemetry-redis_test.go

@@ -344,3 +344,73 @@ func (s *telemetryRedisTemplateTest) TestPersistenceDisabledSkipsPVCAndUsesEmpty
 	s.Nil(volumes[0].PersistentVolumeClaim,
 		"redis-data volume should NOT reference a PVC when persistence is disabled")
 }
+
+// TestExistingClaimSkipsPVCAndMountsNamedClaim ensures that
+// persistence.existingClaim points the Deployment at the named PVC and
+// suppresses chart-managed PVC creation — the path for clusters without
+// a dynamic PV provisioner where the operator pre-creates the claim.
+func (s *telemetryRedisTemplateTest) TestExistingClaimSkipsPVCAndMountsNamedClaim() {
+	options := &helm.Options{SetValues: map[string]string{
+		"telemetry.redis.persistence.existingClaim": "my-prebuilt-redis-pvc",
+	}}
+
+	output := helm.RenderTemplate(s.T(), options, s.chartPath, s.releaseName, s.templates)
+
+	s.NotContains(output, "kind: PersistentVolumeClaim",
+		"PVC should not render when persistence.existingClaim is set")
+
+	deployment := s.extractDeployment(output)
+	volumes := deployment.Spec.Template.Spec.Volumes
+	s.Require().Len(volumes, 1, "Deployment should have exactly one volume")
+	s.Equal("redis-data", volumes[0].Name)
+	s.Require().NotNil(volumes[0].PersistentVolumeClaim,
+		"redis-data volume should reference a PVC when existingClaim is set")
+	s.Equal("my-prebuilt-redis-pvc", volumes[0].PersistentVolumeClaim.ClaimName,
+		"claimName should match the user-supplied existingClaim, not the chart-generated name")
+	s.Nil(volumes[0].EmptyDir,
+		"redis-data volume should NOT be emptyDir when existingClaim is set")
+}
+
+// TestExistingClaimIgnoresStorageClassAndSize ensures that size/storageClass
+// have no effect once the user has taken over claim provisioning via
+// existingClaim — the chart has no PVC to apply them to.
+func (s *telemetryRedisTemplateTest) TestExistingClaimIgnoresStorageClassAndSize() {
+	options := &helm.Options{SetValues: map[string]string{
+		"telemetry.redis.persistence.existingClaim": "my-prebuilt-redis-pvc",
+		"telemetry.redis.persistence.size":          "100Gi",
+		"telemetry.redis.persistence.storageClass":  "gp3",
+	}}
+
+	output := helm.RenderTemplate(s.T(), options, s.chartPath, s.releaseName, s.templates)
+
+	s.NotContains(output, "kind: PersistentVolumeClaim",
+		"PVC should not render when existingClaim is set, even with size/storageClass")
+	s.NotContains(output, "100Gi",
+		"size should not leak into the rendered output when existingClaim is set")
+	s.NotContains(output, "storageClassName",
+		"storageClassName should not appear in any rendered object when existingClaim is set")
+}
+
+// TestPersistenceDisabledBeatsExistingClaim ensures persistence.enabled=false
+// remains the kill-switch — even with existingClaim set, the user opting out
+// of persistence should yield an emptyDir volume rather than a stale claim
+// mount.
+func (s *telemetryRedisTemplateTest) TestPersistenceDisabledBeatsExistingClaim() {
+	options := &helm.Options{SetValues: map[string]string{
+		"telemetry.redis.persistence.enabled":       "false",
+		"telemetry.redis.persistence.existingClaim": "my-prebuilt-redis-pvc",
+	}}
+
+	output := helm.RenderTemplate(s.T(), options, s.chartPath, s.releaseName, s.templates)
+
+	s.NotContains(output, "kind: PersistentVolumeClaim",
+		"PVC should not render when persistence.enabled=false")
+
+	deployment := s.extractDeployment(output)
+	volumes := deployment.Spec.Template.Spec.Volumes
+	s.Require().Len(volumes, 1)
+	s.NotNil(volumes[0].EmptyDir,
+		"persistence.enabled=false should take precedence and yield an emptyDir volume")
+	s.Nil(volumes[0].PersistentVolumeClaim,
+		"redis-data volume should NOT reference the existingClaim when persistence is disabled")
+}