install_module_from_forge_on should require a version constraint string

[jhoblitt]

I have been writing something like this when I always want the latest version of a forge module:

install_module_from_forge_on(host, mod, '> 1')

This feels a bit silly. It would be preferable if #install_module_from_forge, #install_module_from_forge_on and #module_version_from_requirement didn't require a version constraint string and it being absent indicates that the latest forge version should be installed.

[ekohl]

I'd say it should default to > 0 for maximum compatibility. However, I'm working on deprecating this entire gem and moving to another. There I already have it default to nil and then it doesn't pass in the version at all, trusting puppet module install to do the right thing.

https://github.com/voxpupuli/beaker_puppet_helpers/blob/422c1ec0dce9a391927a6e0b2c1f7f040fff49bd/lib/beaker_puppet_helpers/module_utils.rb#L9-L29

[jhoblitt]

I wasn't aware of beaker_puppet_helpers, maybe we could add a link in the README from this module? How soon do you think voxpupuli-test will be able to switch over?

[ekohl]

It's still very fresh, but I opened voxpupuli/voxpupuli-acceptance#31. I'm at the point where I should be doing some testing with it to see if it can replace the various gems. However, we're also in the middle of preparing for Foreman 3.2 so I probably won't have time to do so in the next week or 2.