Remove legacy backwards-compatible data types

When data types where added in version 5.4.0 a few years ago (#117),
backward compatibility with old catalog that used String for all
parameters was preserved.

We already did a few major releases so keeping this backward
compatibility does not make sense and we can make the types more
consistent by removing them.

Author: smortex

REFERENCE.md

@@ -1026,7 +1026,7 @@ The address of the Bacula File server daemon
 
 ##### <a name="-bacula--director--client--port"></a>`port`
 
-Data type: `Variant[String[1],Stdlib::Port]`
+Data type: `Stdlib::Port`
 
 The port of the Bacula File server daemon
 
@@ -1344,7 +1344,7 @@ Default value: `undef`
 
 ##### <a name="-bacula--director--pool--maxvoljobs"></a>`maxvoljobs`
 
-Data type: `Optional[Variant[String[1],Integer[1]]]`
+Data type: `Optional[Integer[1]]`
 
 Bacula pool configuration option "Maximum Volume Jobs"
 
@@ -1360,7 +1360,7 @@ Default value: `undef`
 
 ##### <a name="-bacula--director--pool--maxvols"></a>`maxvols`
 
-Data type: `Optional[Variant[String[1],Integer[1]]]`
+Data type: `Optional[Integer[1]]`
 
 Bacula pool configuration option "Maximum Volumes"
 

manifests/director/client.pp

@@ -23,13 +23,13 @@
 #   }
 #
 define bacula::director::client (
-  String[1]                       $address,
-  Variant[String[1],Stdlib::Port] $port, # FIXME: Remove String
-  Bacula::Password                $password,
-  Bacula::Time                    $file_retention,
-  Bacula::Time                    $job_retention,
-  Bacula::Yesno                   $autoprune,
-  Stdlib::Absolutepath            $conf_dir = $bacula::conf_dir,
+  String[1]            $address,
+  Stdlib::Port         $port,
+  Bacula::Password     $password,
+  Bacula::Time         $file_retention,
+  Bacula::Time         $job_retention,
+  Bacula::Yesno        $autoprune,
+  Stdlib::Absolutepath $conf_dir = $bacula::conf_dir,
 ) {
   $epp_client_variables = {
     name           => $name,

manifests/director/pool.pp

@@ -29,19 +29,19 @@
 #   }
 #
 define bacula::director::pool (
-  Optional[Bacula::Time]                  $volret         = undef,
-  Optional[Variant[String[1],Integer[1]]] $maxvoljobs     = undef, # FIXME: Remove String
-  Optional[Bacula::Size]                  $maxvolbytes    = undef,
-  Optional[Variant[String[1],Integer[1]]] $maxvols        = undef, # FIXME: Remove String
-  Optional[String[1]]                     $label          = undef,
-  Optional[Bacula::Time]                  $voluseduration = undef,
-  String[1]                               $storage        = $bacula::director::storage,
-  String[1]                               $pooltype       = 'Backup',
-  Bacula::Yesno                           $recycle        = true,
-  Bacula::Yesno                           $autoprune      = true,
-  String[1]                               $purgeaction    = 'Truncate',
-  Optional[String[1]]                     $next_pool      = undef,
-  Stdlib::Absolutepath                    $conf_dir       = $bacula::conf_dir,
+  Optional[Bacula::Time] $volret         = undef,
+  Optional[Integer[1]]   $maxvoljobs     = undef,
+  Optional[Bacula::Size] $maxvolbytes    = undef,
+  Optional[Integer[1]]   $maxvols        = undef,
+  Optional[String[1]]    $label          = undef,
+  Optional[Bacula::Time] $voluseduration = undef,
+  String[1]              $storage        = $bacula::director::storage,
+  String[1]              $pooltype       = 'Backup',
+  Bacula::Yesno          $recycle        = true,
+  Bacula::Yesno          $autoprune      = true,
+  String[1]              $purgeaction    = 'Truncate',
+  Optional[String[1]]    $next_pool      = undef,
+  Stdlib::Absolutepath   $conf_dir       = $bacula::conf_dir,
 ) {
   $epp_pool_variables = {
     name           => $name,