storage setting in pool.conf should not force `-sd` suffix

[jflorian]

With the upgrade to 5.2 it became necessary for me to the storage parameter when using the bacula::director::pool resource. I set this to the FQDN of my storage host, but the director now won't start because the pool.conf file now has bacula-sd.mydomain.org-sd.

[zachfi]

This seems like something I missed in the 5.x upgrade. I'll have to look for all instances in the template of -sd etc.

[jflorian]

Bah! I made a comment on the PR rather here. I can make this work now by changing what I pass for storage to bacula::director::pool. However, I'd like to unify things so that the name in storage.conf and the storage name in pool.conf come from a single Hiera setting. Since I'm just using a default storage setup, it looks like I'd need to pass the unified value to bacula::storage::storage.

[zachfi]

Hi @jflorian. Were you able to work around this issue? Does this still need to be addressed?

[jflorian]

@xaque208 , I'm still using the same approached described above. It seems it could/should be simpler, but I haven't had time to dig deeper.

[zachfi]

If you get a chance to look a little closer @jflorian, just let me know if this can be closed out.

[jflorian]

It's unlikely to happen by me any time soon. (Blockers (other projects) before annoyances, ya know.) Feel free to close this out if you'd rather not have it clutter things.

[zachfi]

Thanks @jflorian. Yeah, not trying to hassle. Mostly realizing there has been a bunch of issues that I've been neglecting. I'll have a review of the code, maybe this weekend and see what needs doing.