(enhancement) 'Enabled' is missing for job definition

[PietjePu]

I succesfully put our bacula configuration in puppet the past couple of weeks and very pleased how the module works, but because we have old jobs which are only there for restore-purposes we need the 'Enabled = yes|no' option for job definitions.

Is it possible to include it? I can add it manually, but that will break when I update the module...

Thanks in advance!

[smortex]

Hey @PietjePu!

Have you considered opening a Pull Request (PR) to add your change 😉? This look like a perfect enhancement for a first-time contributor!

If you do not know how to start, here is a quite complete guide about the process of contributing to projects on GitHub:
https://www.dataschool.io/how-to-contribute-on-github/

In any case, do not feel scared: we are here to help!

[PietjePu]

Thanks! As you guessed I don't have any experience regarding contributing to projects. Apart from the 'job enabled'-option, I'm missing autochanger configuration as well. Will that be something useful to add as well? Or is there a reason it's not included? I'm happy to add it and share the code...

[smortex]

The goal for a module is to benefit to the most people, so if you have the usage of the autocharger and can contribute it, we will be happy to merge it! We try to keep the test suite in good shape to ensure the code does not break.

I would recommend you start with adding 'Enabled' which will have less "moving pieces" and will still make you interact with multiple main aspects of contributing to Free Software: try to implement and test the changes on your machine, when ready (or if you are blocked) open a PR. We will then guide you to add tests to ensure your new feature is not broken in the future.

Thanks!

[PietjePu]

You're right. I'll start with the enabled setting. For now I included everything (including the autochanger configuration) in my local copy of the module (seems to work OK, but you never know), because I need the functionality on a short notice. When everything is OK I'll get back and open a pr for the enabled-setting! Thanks so far!