Skip to content

Firewall direct rules get stuck in permanent when subsequent exec reload get skipped #276

Description

@isqo

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 4
  • Distribution: rhel 7
  • Module version: V4.2.4

How to reproduce

1 - set a dependency between Exec[Firewalld::reload] and another puppet resource that fails in your manifest
2 - add a configuration of a direct rule in hiera or in you manifest
3 - sync your code and deploy

What are you seeing

The direct rule getting deployed in the permanent stage but the reload doesn't execute (skipped). Consequently, it stays inactive in the permanent area waiting for a subsequent reload to occur in the future to get deployed.

What behaviour did you expect instead

if the direct rule isn't present in the Runtime stage, it shouldn't be considered deployed

Any additional information you'd like to impart

is there any reason behind checking rules' existence with the permanent flag ?
i observed the same behavior occuring for the other rules

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions