[database] Use dburl variable properly

Author: Joris29

manifests/config.pp

@@ -161,14 +161,7 @@
     change_dbpassword => $jira::change_dbpassword,
     dbtype => $dbtype,
     dbschema => $dbschema,
-    dburl => pick($jira::dburl, $jira::db ? {
-        'postgresql' => "jdbc:${jira::db}://${jira::dbserver}:${dbport}/${jira::dbname}",
-        'mysql'      => "jdbc:${jira::db}://${jira::dbserver}:${dbport}/${jira::dbname}?useUnicode=true&characterEncoding=UTF8&sessionVariables=default_storage_engine=InnoDB",
-        'oracle'     => "jdbc:${jira::db}:thin:@${jira::dbserver}:${dbport}${oracle_separator}${jira::dbname}",
-        'sqlserver'  => "jdbc:jtds:${jira::db}://${jira::dbserver}:${dbport}/${jira::dbname}",
-        'h2'         => "jdbc:h2:file:/${jira::homedir}/database/${jira::dbname}",
-      }
-    ),
+    dburl => $dburl,
     dbdriver => $dbdriver,
     dbuser => $jira::dbuser,
     dbpassword => $jira::dbpassword,

spec/classes/jira_config_spec.rb

@@ -305,6 +305,20 @@ def self.clear_cache
             end
           end
 
+          context 'oracle custom dburl' do
+            let(:params) do
+              super().merge(
+                db: 'oracle',
+                dburl: 'jdbc:oracle:thin:@localhost:1521/mydatabase'
+              )
+            end
+
+            it do
+              is_expected.to contain_file(FILENAME_DBCONFIG_XML).
+                with_content(%r{jdbc:oracle:thin:@localhost:1521/mydatabase})
+            end
+          end
+
           context 'postgres params' do
             let(:params) do
               super().merge(