puppet-lint-strict_indent-check --fix makes it worse instead of better

[shibumi]

Hi,

We have the following code:

  file { ['/opt/foo/var',
          '/opt/foo/log',
          '/opt/foo/bar']:
    ensure => directory,
    owner  => 'root',
    group  => 'root',
    mode   => '0755',
  }

The formatter makes out of this perfectly fine code something like this:

  file { ['/opt/dbe/dirtdb',
      '/opt/dbe/log',
    '/opt/dbe/sox']:
      ensure => directory,
      owner  => 'root',
      group  => 'root',
      mode   => '0755',
  }

This is not the only occurence. Looks like the formatter is formatting code incorrectly in several other places as well.
For example in one occurence it made out of a file:

class bar::foo {
...
exec { 'foobarbazinga':
    command => '/usr/sbin/command',
    unless  => '/usr/sbin/command2',
  }
}

Something like this:

class bar::foo {
...
exec { 'foobarbazinga':
    command => '/usr/sbin/command',
    unless  => '/usr/sbin/command2',
} }

[paran1]

Personally I like the way your first example is indented, but most puppet-lint checks tend to follow the pyppet style guide and according to that your example is not OK. When breaking arrays you should only have one element per line, indented one level, with no elements on the same lines as the opening/closing brackets.
https://www.puppet.com/docs/puppet/8/style_guide.html#arrays-hashes

I agree that --fix does make this code worse, but at least it will only hit code that are already "incorrectly" indented according to the style guide.

After adding two newlines manually the fix results in this:

class test {
  file { [
      '/opt/foo/var',
      '/opt/foo/log',
      '/opt/foo/bar',
    ]:
      ensure => directory,
      owner  => 'root',
      group  => 'root',
      mode   => '0755',
  }
}

Note that the files are intented two extra levels, one for the { and another for the [. Not sure if it is a bug or not? Personally I would only indent one level, even if the closing bracket gets on the same indentation level as the file resource:

file { [
  'file1',
  'file2',
]:
  ensure => file,
}

Your second example seems to be indented correctly using the current version of this plugin:

$ puppet-lint --only-checks strict_indent --fix test2.pp 
FIXED: indent should be 2 chars and is 0 on line 2 (check: strict_indent)
FIXED: indent should be 2 chars and is 0 on line 3 (check: strict_indent)
$ cat test2.pp 
class bar::foo {
  ...
  exec { 'foobarbazinga':
    command => '/usr/sbin/command',
    unless  => '/usr/sbin/command2',
  }
}