Stricter data types

Author: ekohl

manifests/init.pp

@@ -49,14 +49,14 @@
   Variant[Stdlib::Absolutepath, Boolean] $client_body_temp_path = $nginx::params::client_body_temp_path,
   Boolean $confd_only                                        = false,
   Boolean $confd_purge                                       = false,
-  $conf_dir                                                  = $nginx::params::conf_dir,
+  Stdlib::Absolutepath $conf_dir                             = $nginx::params::conf_dir,
   Optional[Enum['on', 'off']] $daemon                        = undef,
-  $daemon_user                                               = $nginx::params::daemon_user,
-  $daemon_group                                              = undef,
+  String[1] $daemon_user                                     = $nginx::params::daemon_user,
+  Optional[String[1]] $daemon_group                          = undef,
   Array[String] $dynamic_modules                             = [],
-  $global_owner                                              = $nginx::params::global_owner,
-  $global_group                                              = $nginx::params::global_group,
-  $global_mode                                               = $nginx::params::global_mode,
+  String[1] $global_owner                                    = $nginx::params::global_owner,
+  String[1] $global_group                                    = $nginx::params::global_group,
+  Stdlib::Filemode $global_mode                              = $nginx::params::global_mode,
   Optional[Variant[String[1], Array[String[1]]]] $limit_req_zone = undef,
   Stdlib::Absolutepath $log_dir                              = $nginx::params::log_dir,
   String[1] $log_user                                        = $nginx::params::log_user,
@@ -66,20 +66,20 @@
   $http_format_log                                           = undef,
   Variant[String, Array[String]] $nginx_error_log            = "${log_dir}/${nginx::params::nginx_error_log_file}",
   Nginx::ErrorLogSeverity $nginx_error_log_severity          = 'error',
-  $pid                                                       = $nginx::params::pid,
+  Variant[Stdlib::Absolutepath, Boolean] $pid                = $nginx::params::pid,
   Variant[Stdlib::Absolutepath, Boolean] $proxy_temp_path    = $nginx::params::proxy_temp_path,
-  $root_group                                                = $nginx::params::root_group,
-  $run_dir                                                   = $nginx::params::run_dir,
+  String[1] $root_group                                      = $nginx::params::root_group,
+  Stdlib::Absolutepath $run_dir                              = $nginx::params::run_dir,
   $sites_available_owner                                     = $nginx::params::sites_available_owner,
   $sites_available_group                                     = $nginx::params::sites_available_group,
   $sites_available_mode                                      = $nginx::params::sites_available_mode,
   Boolean $super_user                                        = $nginx::params::super_user,
-  $temp_dir                                                  = $nginx::params::temp_dir,
+  Stdlib::Absolutepath $temp_dir                             = $nginx::params::temp_dir,
   Boolean $server_purge                                      = false,
   Boolean $include_modules_enabled                           = $nginx::params::include_modules_enabled,
 
   # Primary Templates
-  $conf_template                                             = 'nginx/conf.d/nginx.conf.erb',
+  String[1] $conf_template                                   = 'nginx/conf.d/nginx.conf.erb',
 
   ### START Nginx Configuration ###
   Optional[Enum['on', 'off']] $absolute_redirect             = undef,

manifests/resource/mailhost.pp

@@ -102,10 +102,10 @@
   Optional[String] $ssl_trusted_cert             = undef,
   Optional[Integer] $ssl_verify_depth            = undef,
   Enum['on', 'off', 'only'] $starttls            = 'off',
-  $protocol                                      = undef,
+  Optional[Enum['imap', 'pop3', 'smtp']] $protocol = undef,
   Optional[String] $auth_http                    = undef,
   Optional[String] $auth_http_header             = undef,
-  String $xclient                                = 'on',
+  Enum['on', 'off'] $xclient                     = 'on',
   Optional[String] $imap_auth                    = undef,
   Optional[Array] $imap_capabilities             = undef,
   Optional[String] $imap_client_buffer           = undef,

spec/defines/resource_mailhost_spec.rb

@@ -96,14 +96,14 @@
             {
               title: 'should set protocol',
               attr: 'protocol',
-              value: 'test-protocol',
-              match: '  protocol              test-protocol;'
+              value: 'imap',
+              match: '  protocol              imap;'
             },
             {
               title: 'should set xclient',
               attr: 'xclient',
-              value: 'test-xclient',
-              match: '  xclient               test-xclient;'
+              value: 'off',
+              match: '  xclient               off;'
             },
             {
               title: 'should set auth_http',
@@ -533,14 +533,14 @@
             {
               title: 'should set protocol',
               attr: 'protocol',
-              value: 'test-protocol',
-              match: '  protocol              test-protocol;'
+              value: 'imap',
+              match: '  protocol              imap;'
             },
             {
               title: 'should set xclient',
               attr: 'xclient',
-              value: 'test-xclient',
-              match: '  xclient               test-xclient;'
+              value: 'off',
+              match: '  xclient               off;'
             },
             {
               title: 'should set auth_http',