Request for comment on refactoring

[tuxmea]

I would like to receive comments on my ideas on how to refactor this module:

1. replace params class with hiera data
2. re-enable the old webhook (this allows people to migrate)
3. rework the new webhook-go implementation (allow self hosted repository or webserver Webhook-go url is hardcoded #606)
4. add documentation on how to configure webhook-go

Feedback is welcome.

[smortex]

Not a user of the module so I won't comment of the behavior itself :)

replace params class with hiera data

👍 params.pp is a smell, default values should go in init.pp and if OS-dependant in hiera.

[kenyon]

I'm using this module, and this sounds good to me.

[ardichoke]

I'm using this module and your proposal sounds good. So far, I find webhook-go to be a mess and horribly immature. The project doesn't even have documentation about what endpoints to send webhooks to (and when I figured it out by digging through code, sending a test webhook caused a runtime error).

The documentation is also a mess, following it results in puppet errors.

I'm really disappointed in the voxpupuli community with this one, whomever decided the entire change to webhook-go was in a good enough state to ship shouldn't be trusted to make those decisions in the future.