replace redis.service.epp

[TheMeier]

use systemd::manage_unit instead of templates/service_remplates/redis.service.epp

[ekohl]

I always liked that Debian already provided redis-server@.service and allows you to create additional instances that way, but Red Hat doesn't have an equivalent. I still think that using redis-server@.service is a good thing to support, but I don't have the time to work on this myself.

[TheMeier]

I personally think setting manage_service to false and manage service and drop-ins in your profiles/roles using the package provided unit(-templates) is a much cleaner way in that case. Also we maybe might want to start to refuse changes like this: #567 and tell people to use systemd drop-ins

[ekohl]

I personally think setting manage_service to false and manage service and drop-ins in your profiles/roles using the package provided unit(-templates) is a much cleaner way in that case.

Agreed and we already do that for the "default" service:

puppet-redis/manifests/init.pp

Line 401 in acbd2ee

Boolean $manage_service_file = false,

Ideally the module would also be refactored so redis::instance uses redis-server@.service while redis uses redis-server.service (or redis.service on EL). It already does the last part.

So my suggestion would be to make https://github.com/voxpupuli/puppet-redis/blob/master/templates/service_templates/redis.service.epp create a redis@.service on EL < 10 and valkey@.service on EL >= 10 while using the built in from Debian.

Then indeed as you say, tell users to use drop ins to override specifics.