From b50846da9182e9b205e9f58953c99c7676a8ff6f Mon Sep 17 00:00:00 2001 From: Tim Meusel Date: Tue, 26 Nov 2024 11:15:36 +0100 Subject: [PATCH 1/2] CI: Test if we can build puppetboard In our normal test pipeline, we didn't verify if we can properly build the package. because of that, the last 6.0.0 release failed: ``` Run python setup.py build sdist bdist_wheel Traceback (most recent call last): File "/home/runner/work/puppetboard/puppetboard/setup.py", line 3, in from setuptools.command.test import test as TestCommand ModuleNotFoundError: No module named 'setuptools' ``` --- .github/workflows/tests.yml | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 84ff3422..17060853 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -12,7 +12,6 @@ jobs: runs-on: ubuntu-latest strategy: - max-parallel: 5 matrix: python-version: [3.9, '3.10', 3.11, 3.12, 3.13] @@ -40,6 +39,23 @@ jobs: run: | poetry build -v + # this uses the same commands as in our release pipeline and ensures that we can still build puppetboard + test-build: + runs-on: ubuntu-latest + strategy: + matrix: + python-version: [3.9, '3.10', 3.11, 3.12, 3.13] + steps: + - uses: actions/checkout@v4 + - name: Set up Python ${{ matrix.python-version }} + uses: actions/setup-python@v5 + with: + python-version: ${{ matrix.python-version }} + - name: Install dependencies + run: pip install wheel + - name: Build + run: python setup.py build sdist bdist_wheel + build_docker_image: name: 'Test building a container' runs-on: ubuntu-latest @@ -71,6 +87,7 @@ jobs: tests: needs: - test + - test-build - build_docker_image - security-tests runs-on: ubuntu-latest From 7db4777dab7928955d690de665e87216da9544a5 Mon Sep 17 00:00:00 2001 From: Tim Meusel Date: Tue, 26 Nov 2024 11:30:30 +0100 Subject: [PATCH 2/2] build pipeline: install setuptools --- .github/workflows/tests.yml | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 17060853..9f8e62b3 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -13,7 +13,12 @@ jobs: strategy: matrix: - python-version: [3.9, '3.10', 3.11, 3.12, 3.13] + python-version: + - 3.9 + - '3.10' + - 3.11 + - 3.12 + - 3.13 steps: - uses: actions/checkout@v4 @@ -44,7 +49,13 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - python-version: [3.9, '3.10', 3.11, 3.12, 3.13] + python-version: + - 3.9 + - '3.10' + - 3.11 + - 3.12 + - 3.13 + steps: - uses: actions/checkout@v4 - name: Set up Python ${{ matrix.python-version }} @@ -52,7 +63,7 @@ jobs: with: python-version: ${{ matrix.python-version }} - name: Install dependencies - run: pip install wheel + run: pip install wheel setuptools - name: Build run: python setup.py build sdist bdist_wheel