Skip to content

improved morph target primitive validation #133

improved morph target primitive validation

improved morph target primitive validation #133

Triggered via push July 12, 2025 12:35
Status Success
Total duration 3m 27s
Artifacts

TestCommit.yml

on: push
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

30 warnings and 2 notices
build (macos-latest): build/SharpGLTF.CodeGen.Core/CodeGen/CSharpEmitter.RuntimeField.cs#L17
Type '_RuntimeField' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
build (macos-latest): build/SharpGLTF.CodeGen.Core/CodeGen/EmitCSharp.cs#L535
Type 'CSharpClassEmitter' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
build (macos-latest): build/SharpGLTF.CodeGen.Core/CodeGen/CSharpEmitter.RuntimeType.cs#L17
Type '_RuntimeType' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
build (macos-latest): build/SharpGLTF.CodeGen.Core/CodeGen/CSharpEmitter.RuntimeEnum.cs#L15
Type '_RuntimeEnum' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
build (macos-latest): build/SharpGLTF.CodeGen.Core/SchemaReflection/SchemaTypesContext.cs#L66
Method UseBlittable passes parameter name 't' as the message argument to a ArgumentException constructor. Replace this argument with a descriptive message and pass the parameter name in the correct position. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)
build (macos-latest): build/SharpGLTF.CodeGen.Core/SchemaProcessing.cs#L58
Change return type of method '_Resolver' from 'NJsonSchema.JsonReferenceResolver' to 'SharpGLTF.SchemaProcessing.MyReferenceResolver' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859)
build (macos-latest): build/SharpGLTF.CodeGen.Core/SchemaDownload.cs#L12
Change the type of parameter 'remoteUrl' of method 'SchemaDownload.Syncronize(string, string)' from 'string' to 'System.Uri', or provide an overload to 'SchemaDownload.Syncronize(string, string)' that allows 'remoteUrl' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
build (macos-latest): build/SharpGLTF.CodeGen.Core/CodeGen/EmitCSharp.cs#L622
'string.Replace(string, string?)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'SharpGLTF.CodeGen.CSharpClassEmitter.AddFieldReflection(SharpGLTF.SchemaReflection.FieldInfo)' with a call to 'string.Replace(string, string?, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
build (macos-latest): build/SharpGLTF.CodeGen.Core/CodeGen/CodeEmitUtils.cs#L30
Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1861)
build (macos-latest): build/SharpGLTF.CodeGen.Core/CodeGen/EmitCSharp.cs#L27
Field 'CSharpEmitter._FieldsBrowsableState' is never assigned to, and will always have its default value
build (ubuntu-latest): build/SharpGLTF.CodeGen.Core/CodeGen/CSharpEmitter.RuntimeEnum.cs#L15
Type '_RuntimeEnum' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
build (ubuntu-latest): build/SharpGLTF.CodeGen.Core/CodeGen/CSharpEmitter.RuntimeType.cs#L17
Type '_RuntimeType' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
build (ubuntu-latest): build/SharpGLTF.CodeGen.Core/CodeGen/EmitCSharp.cs#L535
Type 'CSharpClassEmitter' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
build (ubuntu-latest): build/SharpGLTF.CodeGen.Core/CodeGen/CSharpEmitter.RuntimeField.cs#L17
Type '_RuntimeField' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
build (ubuntu-latest): build/SharpGLTF.CodeGen.Core/SchemaReflection/SchemaTypesContext.cs#L66
Method UseBlittable passes parameter name 't' as the message argument to a ArgumentException constructor. Replace this argument with a descriptive message and pass the parameter name in the correct position. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)
build (ubuntu-latest): build/SharpGLTF.CodeGen.Core/SchemaProcessing.cs#L58
Change return type of method '_Resolver' from 'NJsonSchema.JsonReferenceResolver' to 'SharpGLTF.SchemaProcessing.MyReferenceResolver' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859)
build (ubuntu-latest): build/SharpGLTF.CodeGen.Core/SchemaDownload.cs#L12
Change the type of parameter 'remoteUrl' of method 'SchemaDownload.Syncronize(string, string)' from 'string' to 'System.Uri', or provide an overload to 'SchemaDownload.Syncronize(string, string)' that allows 'remoteUrl' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
build (ubuntu-latest): build/SharpGLTF.CodeGen.Core/CodeGen/EmitCSharp.cs#L622
'string.Replace(string, string?)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'SharpGLTF.CodeGen.CSharpClassEmitter.AddFieldReflection(SharpGLTF.SchemaReflection.FieldInfo)' with a call to 'string.Replace(string, string?, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
build (ubuntu-latest): build/SharpGLTF.CodeGen.Core/CodeGen/CodeEmitUtils.cs#L30
Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1861)
build (ubuntu-latest): build/SharpGLTF.CodeGen.Core/CodeGen/EmitCSharp.cs#L27
Field 'CSharpEmitter._FieldsBrowsableState' is never assigned to, and will always have its default value
build (windows-latest): src/SharpGLTF.Core/Schema2/gltf.AnimationChannelTarget.cs#L206
Prefer 'AsSpan' over 'Substring' when span-based overloads are available (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1846)
build (windows-latest): src/SharpGLTF.Core/Schema2/gltf.ExtraProperties.cs#L316
'val' is never 'null'. Remove or refactor the condition(s) to avoid dead code. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1508)
build (windows-latest): src/SharpGLTF.Core/Schema2/gltf.ExtraProperties.cs#L108
'this is IReflectionObject robj' is always 'true'. Remove or refactor the condition(s) to avoid dead code. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1508)
build (windows-latest): src/SharpGLTF.Core/Schema2/Serialization.ReadContext.cs#L111
Change the type of parameter 'relativeUri' of method 'ReadContext.TryGetFullPath(string, out string)' from 'string' to 'System.Uri', or provide an overload to 'ReadContext.TryGetFullPath(string, out string)' that allows 'relativeUri' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
build (windows-latest): src/SharpGLTF.Core/Memory/IAccessorArray.cs#L51
Initialize all static fields in 'ZeroAccessorArray' when those fields are declared and remove the explicit static constructor (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2207)
build (windows-latest): src/SharpGLTF.Core/Validation/ValidationContext.Guards.cs#L132
Change the type of parameter 'gltfURI' of method 'ValidationContext.IsNullOrValidURI(ValueLocation, string, params string[])' from 'string' to 'System.Uri', or provide an overload to 'ValidationContext.IsNullOrValidURI(ValueLocation, string, params string[])' that allows 'gltfURI' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
build (windows-latest): src/SharpGLTF.Core/Validation/ValidationContext.Guards.cs#L138
Change the type of parameter 'gltfURI' of method 'ValidationContext.IsValidURI(ValueLocation, string, params string[])' from 'string' to 'System.Uri', or provide an overload to 'ValidationContext.IsValidURI(ValueLocation, string, params string[])' that allows 'gltfURI' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
build (windows-latest): src/SharpGLTF.Core/Memory/MemoryImage.cs#L475
Modify '_IsKtx2Image' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
build (windows-latest): src/SharpGLTF.Core/IO/JsonSerializable.cs#L456
'reader.TokenType == JSONTOKEN.StartObject' is always 'false'. Remove or refactor the condition(s) to avoid dead code. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1508)
build (windows-latest): src/SharpGLTF.Core/Memory/MemoryImage.cs#L278
Modify 'get_IsValid' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
build (macos-latest)
The macos-latest label will migrate to macOS 15 beginning August 4, 2025. For more information see https://github.com/actions/runner-images/issues/12520
build (macos-latest)
The macos-latest label will migrate to macOS 15 beginning August 4, 2025. For more information see https://github.com/actions/runner-images/issues/12520