Moved SharpGltf.Codegen.Core to Src so it can be published as a package #134
Annotations
30 warnings and 2 notices
|
build (macos-latest):
src/SharpGLTF.Core/Schema2/gltf.AnimationChannelTarget.cs#L206
Prefer 'AsSpan' over 'Substring' when span-based overloads are available (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1846)
|
|
build (macos-latest):
src/SharpGLTF.Core/Memory/MemoryImage.cs#L475
Modify '_IsKtx2Image' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
|
|
build (macos-latest):
src/SharpGLTF.Core/IO/JsonSerializable.cs#L456
'reader.TokenType == JSONTOKEN.StartObject' is always 'false'. Remove or refactor the condition(s) to avoid dead code. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1508)
|
|
build (macos-latest):
src/SharpGLTF.Core/Memory/MemoryImage.cs#L278
Modify 'get_IsValid' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
|
|
build (macos-latest):
src/SharpGLTF.CodeGen.Core/CodeGen/EmitCSharp.cs#L364
The behavior of 'StringBuilder.AppendLine(ref StringBuilder.AppendInterpolatedStringHandler)' could vary based on the current user's locale settings. Replace this call in 'CSharpEmitter.EmitContext(SchemaType.Context)' with a call to 'StringBuilder.AppendLine(IFormatProvider, ref StringBuilder.AppendInterpolatedStringHandler)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
build (macos-latest):
src/SharpGLTF.CodeGen.Core/SchemaReflection/SchemaTypesContext.cs#L66
Method UseBlittable passes parameter name 't' as the message argument to a ArgumentException constructor. Replace this argument with a descriptive message and pass the parameter name in the correct position. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)
|
|
build (macos-latest):
src/SharpGLTF.CodeGen.Core/SchemaProcessing.cs#L58
Change return type of method '_Resolver' from 'NJsonSchema.JsonReferenceResolver' to 'SharpGLTF.SchemaProcessing.MyReferenceResolver' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859)
|
|
build (macos-latest):
src/SharpGLTF.CodeGen.Core/SchemaDownload.cs#L12
Change the type of parameter 'remoteUrl' of method 'SchemaDownload.Syncronize(string, string)' from 'string' to 'System.Uri', or provide an overload to 'SchemaDownload.Syncronize(string, string)' that allows 'remoteUrl' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
|
|
build (macos-latest):
src/SharpGLTF.CodeGen.Core/CodeGen/EmitCSharp.cs#L622
'string.Replace(string, string?)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'SharpGLTF.CodeGen.CSharpClassEmitter.AddFieldReflection(SharpGLTF.SchemaReflection.FieldInfo)' with a call to 'string.Replace(string, string?, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
|
|
build (macos-latest):
src/SharpGLTF.CodeGen.Core/CodeGen/EmitCSharp.cs#L27
Field 'CSharpEmitter._FieldsBrowsableState' is never assigned to, and will always have its default value
|
|
build (ubuntu-latest):
tests/SharpGLTF.DownloadTestFiles/DownloadUtils.cs#L46
Method DownloadFile passes parameter name 'localFilePath' as the message argument to a ArgumentException constructor. Replace this argument with a descriptive message and pass the parameter name in the correct position. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)
|
|
build (ubuntu-latest):
tests/SharpGLTF.DownloadTestFiles/DownloadUtils.cs#L15
Method SyncronizeGitRepository passes parameter name 'localDirectoryPath' as the message argument to a ArgumentException constructor. Replace this argument with a descriptive message and pass the parameter name in the correct position. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)
|
|
build (ubuntu-latest):
tests/SharpGLTF.DownloadTestFiles/ExampleFiles.cs#L70
Unused field '_BabylonJsInvalidFiles' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1823)
|
|
build (ubuntu-latest):
tests/SharpGLTF.DownloadTestFiles/DownloadUtils.cs#L57
'WebClient.WebClient()' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead.' (https://aka.ms/dotnet-warnings/SYSLIB0014)
|
|
build (ubuntu-latest):
src/SharpGLTF.CodeGen.Core/SchemaProcessing.cs#L58
Change return type of method '_Resolver' from 'NJsonSchema.JsonReferenceResolver' to 'SharpGLTF.SchemaProcessing.MyReferenceResolver' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859)
|
|
build (ubuntu-latest):
src/SharpGLTF.CodeGen.Core/SchemaReflection/SchemaTypesContext.cs#L66
Method UseBlittable passes parameter name 't' as the message argument to a ArgumentException constructor. Replace this argument with a descriptive message and pass the parameter name in the correct position. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)
|
|
build (ubuntu-latest):
src/SharpGLTF.CodeGen.Core/SchemaDownload.cs#L12
Change the type of parameter 'remoteUrl' of method 'SchemaDownload.Syncronize(string, string)' from 'string' to 'System.Uri', or provide an overload to 'SchemaDownload.Syncronize(string, string)' that allows 'remoteUrl' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
|
|
build (ubuntu-latest):
src/SharpGLTF.CodeGen.Core/CodeGen/EmitCSharp.cs#L364
The behavior of 'StringBuilder.AppendLine(ref StringBuilder.AppendInterpolatedStringHandler)' could vary based on the current user's locale settings. Replace this call in 'CSharpEmitter.EmitContext(SchemaType.Context)' with a call to 'StringBuilder.AppendLine(IFormatProvider, ref StringBuilder.AppendInterpolatedStringHandler)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
build (ubuntu-latest):
src/SharpGLTF.CodeGen.Core/CodeGen/EmitCSharp.cs#L622
'string.Replace(string, string?)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'SharpGLTF.CodeGen.CSharpClassEmitter.AddFieldReflection(SharpGLTF.SchemaReflection.FieldInfo)' with a call to 'string.Replace(string, string?, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
|
|
build (ubuntu-latest):
src/SharpGLTF.CodeGen.Core/CodeGen/EmitCSharp.cs#L27
Field 'CSharpEmitter._FieldsBrowsableState' is never assigned to, and will always have its default value
|
|
build (windows-latest):
src/SharpGLTF.Core/Schema2/gltf.Material.cs#L153
In member void Material.OnValidateContent(ValidationContext result), change parameter name result to validate in order to match the identifier as it has been declared in void ExtraProperties.OnValidateContent(ValidationContext validate) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
|
|
build (windows-latest):
src/SharpGLTF.Core/Schema2/gltf.ExtraProperties.cs#L316
'val' is never 'null'. Remove or refactor the condition(s) to avoid dead code. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1508)
|
|
build (windows-latest):
src/SharpGLTF.Core/Schema2/gltf.ExtraProperties.cs#L108
'this is IReflectionObject robj' is always 'true'. Remove or refactor the condition(s) to avoid dead code. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1508)
|
|
build (windows-latest):
src/SharpGLTF.Core/Memory/IAccessorArray.cs#L51
Initialize all static fields in 'ZeroAccessorArray' when those fields are declared and remove the explicit static constructor (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2207)
|
|
build (windows-latest):
src/SharpGLTF.Core/Schema2/Serialization.ReadContext.cs#L111
Change the type of parameter 'relativeUri' of method 'ReadContext.TryGetFullPath(string, out string)' from 'string' to 'System.Uri', or provide an overload to 'ReadContext.TryGetFullPath(string, out string)' that allows 'relativeUri' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
|
|
build (windows-latest):
src/SharpGLTF.Core/Memory/MemoryImage.cs#L475
Modify '_IsKtx2Image' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
|
|
build (windows-latest):
src/SharpGLTF.Core/Memory/MemoryImage.cs#L278
Modify 'get_IsValid' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
|
|
build (windows-latest):
src/SharpGLTF.Core/IO/JsonSerializable.cs#L456
'reader.TokenType == JSONTOKEN.StartObject' is always 'false'. Remove or refactor the condition(s) to avoid dead code. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1508)
|
|
build (windows-latest):
src/SharpGLTF.Core/Validation/ValidationContext.Guards.cs#L138
Change the type of parameter 'gltfURI' of method 'ValidationContext.IsValidURI(ValueLocation, string, params string[])' from 'string' to 'System.Uri', or provide an overload to 'ValidationContext.IsValidURI(ValueLocation, string, params string[])' that allows 'gltfURI' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
|
|
build (windows-latest):
src/SharpGLTF.Core/Validation/ValidationContext.Guards.cs#L132
Change the type of parameter 'gltfURI' of method 'ValidationContext.IsNullOrValidURI(ValueLocation, string, params string[])' from 'string' to 'System.Uri', or provide an overload to 'ValidationContext.IsNullOrValidURI(ValueLocation, string, params string[])' that allows 'gltfURI' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
|
|
build (macos-latest)
The macos-latest label will migrate to macOS 15 beginning August 4, 2025. For more information see https://github.com/actions/runner-images/issues/12520
|
|
build (macos-latest)
The macos-latest label will migrate to macOS 15 beginning August 4, 2025. For more information see https://github.com/actions/runner-images/issues/12520
|