Roslyn trimmer errors for json calls

[xPaw]

I am trying to publish an app that uses SharpGLTF with AOT and PublishTrimmed enabled, and the analyser is producing these errors.

Even if I remove any assignments to Extras, it is producing these errors, so I am not sure it is caused by my usage of sharpgltf.

ILLink : Trim analysis error IL2026: SharpGLTF.Schema2.ExtraProperties.Extras.get: Using member 'System.Text.Json.Nodes.JsonNode.ReplaceWith<T>(T)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Creating JsonValue instances with non-primitive types is not compatible with trimming. It can result in non-primitive types being serialized, which may have their members trimmed.
ILLink : Trim analysis error IL2026: SharpGLTF.Schema2.ExtraProperties.Extras.get: Using member 'System.Text.Json.Nodes.JsonNode.ConvertFromValue<T>(T, Nullable<JsonNodeOptions>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved.
ILLink : Trim analysis error IL2026: SharpGLTF.Schema2.ExtraProperties.Extras.get: Using member 'System.Text.Json.Nodes.JsonNode.ConvertFromValue<T>(T, Nullable<JsonNodeOptions>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved.
ILLink : Trim analysis error IL2026: SharpGLTF.Schema2.ExtraProperties.Extras.get: Using member 'System.Text.Json.Nodes.JsonArray.Add<T>(T)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Creating JsonValue instances with non-primitive types is not compatible with trimming. It can result in non-primitive types being serialized, which may have their members trimmed.
ILLink : Trim analysis error IL2026: SharpGLTF.Schema2.ExtraProperties.Extras.get: Using member 'System.Text.Json.Nodes.JsonNode.ConvertFromValue<T>(T, Nullable<JsonNodeOptions>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved.
ILLink : Trim analysis error IL2026: SharpGLTF.Schema2.ExtraProperties.Extras.get: Using member 'System.Text.Json.Nodes.JsonNode.ReplaceWith<T>(T)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Creating JsonValue instances with non-primitive types is not compatible with trimming. It can result in non-primitive types being serialized, which may have their members trimmed.
ILLink : Trim analysis error IL2026: SharpGLTF.Schema2.ExtraProperties.Extras.get: Using member 'System.Text.Json.Nodes.JsonValue.Create<T>(T, Nullable<JsonNodeOptions>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Creating JsonValue instances with non-primitive types is not compatible with trimming. It can result in non-primitive types being serialized, which may have their members trimmed. Use the overload that takes a JsonTypeInfo, or make sure all of the required types are preserved.
ILLink : Trim analysis error IL2026: SharpGLTF.Schema2.ExtraProperties.Extras.get: Using member 'System.Text.Json.Nodes.JsonNode.ReplaceWith<T>(T)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Creating JsonValue instances with non-primitive types is not compatible with trimming. It can result in non-primitive types being serialized, which may have their members trimmed.
ILLink : Trim analysis error IL2026: SharpGLTF.Schema2.ExtraProperties.Extras.set: Using member 'System.Text.Json.Nodes.JsonNode.ConvertFromValue<T>(T, Nullable<JsonNodeOptions>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved.
ILLink : Trim analysis error IL2026: SharpGLTF.Schema2.ExtraProperties.Extras.set: Using member 'System.Text.Json.Nodes.JsonNode.ConvertFromValue<T>(T, Nullable<JsonNodeOptions>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved.
ILLink : Trim analysis error IL2026: SharpGLTF.Schema2.ExtraProperties.Extras.set: Using member 'System.Text.Json.Nodes.JsonNode.ReplaceWith<T>(T)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Creating JsonValue instances with non-primitive types is not compatible with trimming. It can result in non-primitive types being serialized, which may have their members trimmed.
ILLink : Trim analysis error IL2026: SharpGLTF.Schema2.ExtraProperties.Extras.set: Using member 'System.Text.Json.Nodes.JsonNode.ReplaceWith<T>(T)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Creating JsonValue instances with non-primitive types is not compatible with trimming. It can result in non-primitive types being serialized, which may have their members trimmed.
ILLink : Trim analysis error IL2026: SharpGLTF.Schema2.ExtraProperties.Extras.set: Using member 'System.Text.Json.Nodes.JsonNode.ReplaceWith<T>(T)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Creating JsonValue instances with non-primitive types is not compatible with trimming. It can result in non-primitive types being serialized, which may have their members trimmed.
ILLink : Trim analysis error IL2026: SharpGLTF.Schema2.ExtraProperties.Extras.set: Using member 'System.Text.Json.Nodes.JsonNode.ConvertFromValue<T>(T, Nullable<JsonNodeOptions>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved.
ILLink : Trim analysis error IL2026: SharpGLTF.Schema2.ExtraProperties.Extras.set: Using member 'System.Text.Json.Nodes.JsonArray.Add<T>(T)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Creating JsonValue instances with non-primitive types is not compatible with trimming. It can result in non-primitive types being serialized, which may have their members trimmed.
ILLink : Trim analysis error IL2026: SharpGLTF.Schema2.ExtraProperties.Extras.set: Using member 'System.Text.Json.Nodes.JsonValue.Create<T>(T, Nullable<JsonNodeOptions>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Creating JsonValue instances with non-primitive types is not compatible with trimming. It can result in non-primitive types being serialized, which may have their members trimmed. Use the overload that takes a JsonTypeInfo, or make sure all of the required types are preserved.
ILLink : Trim analysis error IL2026: SharpGLTF.IO.UnknownNode._Properties: Using member 'System.Text.Json.Nodes.JsonNode.ReplaceWith<T>(T)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Creating JsonValue instances with non-primitive types is not compatible with trimming. It can result in non-primitive types being serialized, which may have their members trimmed.
ILLink : Trim analysis error IL2026: SharpGLTF.IO.UnknownNode._Properties: Using member 'System.Text.Json.Nodes.JsonNode.ConvertFromValue<T>(T, Nullable<JsonNodeOptions>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved.
ILLink : Trim analysis error IL2026: SharpGLTF.IO.UnknownNode._Properties: Using member 'System.Text.Json.Nodes.JsonNode.ConvertFromValue<T>(T, Nullable<JsonNodeOptions>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved.
ILLink : Trim analysis error IL2026: SharpGLTF.IO.UnknownNode._Properties: Using member 'System.Text.Json.Nodes.JsonNode.ReplaceWith<T>(T)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Creating JsonValue instances with non-primitive types is not compatible with trimming. It can result in non-primitive types being serialized, which may have their members trimmed.
ILLink : Trim analysis error IL2026: SharpGLTF.IO.UnknownNode._Properties: Using member 'System.Text.Json.Nodes.JsonArray.Add<T>(T)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Creating JsonValue instances with non-primitive types is not compatible with trimming. It can result in non-primitive types being serialized, which may have their members trimmed.
ILLink : Trim analysis error IL2026: SharpGLTF.IO.UnknownNode._Properties: Using member 'System.Text.Json.Nodes.JsonValue.Create<T>(T, Nullable<JsonNodeOptions>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Creating JsonValue instances with non-primitive types is not compatible with trimming. It can result in non-primitive types being serialized, which may have their members trimmed. Use the overload that takes a JsonTypeInfo, or make sure all of the required types are preserved.
ILLink : Trim analysis error IL2026: SharpGLTF.IO.UnknownNode._Properties: Using member 'System.Text.Json.Nodes.JsonNode.ConvertFromValue<T>(T, Nullable<JsonNodeOptions>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved.
ILLink : Trim analysis error IL2026: SharpGLTF.IO.UnknownNode._Properties: Using member 'System.Text.Json.Nodes.JsonNode.ReplaceWith<T>(T)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Creating JsonValue instances with non-primitive types is not compatible with trimming. It can result in non-primitive types being serialized, which may have their members trimmed.
ILLink : Trim analysis error IL2026: SharpGLTF.IO.UnknownNode.DeserializeProperty(String, Utf8JsonReader&): Using member 'System.Text.Json.Nodes.JsonNode.ReplaceWith<T>(T)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Creating JsonValue instances with non-primitive types is not compatible with trimming. It can result in non-primitive types being serialized, which may have their members trimmed.
ILLink : Trim analysis error IL2026: SharpGLTF.IO.UnknownNode.DeserializeProperty(String, Utf8JsonReader&): Using member 'System.Text.Json.Nodes.JsonNode.ConvertFromValue<T>(T, Nullable<JsonNodeOptions>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved.
ILLink : Trim analysis error IL2026: SharpGLTF.IO.UnknownNode.DeserializeProperty(String, Utf8JsonReader&): Using member 'System.Text.Json.Nodes.JsonNode.ReplaceWith<T>(T)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Creating JsonValue instances with non-primitive types is not compatible with trimming. It can result in non-primitive types being serialized, which may have their members trimmed.
ILLink : Trim analysis error IL2026: SharpGLTF.IO.UnknownNode.DeserializeProperty(String, Utf8JsonReader&): Using member 'System.Text.Json.Nodes.JsonNode.ConvertFromValue<T>(T, Nullable<JsonNodeOptions>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved.
ILLink : Trim analysis error IL2026: SharpGLTF.IO.UnknownNode.DeserializeProperty(String, Utf8JsonReader&): Using member 'System.Text.Json.Nodes.JsonValue.Create<T>(T, Nullable<JsonNodeOptions>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Creating JsonValue instances with non-primitive types is not compatible with trimming. It can result in non-primitive types being serialized, which may have their members trimmed. Use the overload that takes a JsonTypeInfo, or make sure all of the required types are preserved.
ILLink : Trim analysis error IL2026: SharpGLTF.IO.UnknownNode.DeserializeProperty(String, Utf8JsonReader&): Using member 'System.Text.Json.Nodes.JsonNode.ConvertFromValue<T>(T, Nullable<JsonNodeOptions>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved.
ILLink : Trim analysis error IL2026: SharpGLTF.IO.UnknownNode.DeserializeProperty(String, Utf8JsonReader&): Using member 'System.Text.Json.Nodes.JsonArray.Add<T>(T)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Creating JsonValue instances with non-primitive types is not compatible with trimming. It can result in non-primitive types being serialized, which may have their members trimmed.
ILLink : Trim analysis error IL2026: SharpGLTF.IO.UnknownNode.DeserializeProperty(String, Utf8JsonReader&): Using member 'System.Text.Json.Nodes.JsonNode.ReplaceWith<T>(T)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Creating JsonValue instances with non-primitive types is not compatible with trimming. It can result in non-primitive types being serialized, which may have their members trimmed.

SharpGLTF.Toolkit 1.0.5

[vpenades]

Are these warnings or errors?

typically the analyser delivers these as warnings, not errors, so unless you've manually raised these from warning to errors, it should not be a problem.

Keep in mind that glTF standard is very dynamic in nature, it was designed with javascript in mind, so it has lots of places that conflict with AOT. I've tried to iron out as many of these issues as possible, but there's a few things like the .Extras or the Unknown object.

What I don't know is from where these errors are coming from, becuase the glTF library itself is not using any of these methods described in the warning. So maybe is a case of the analyzer being too picky just because a type with potentially problematic methods is in use, even if the methods themselves are not being used.

So what I would do is to review the levels of these errors and lower them to just warnings

[xPaw]

Hmm, UnknownNode is being referenced by Extras, so that's probably why it shows up. It is a bit strange that the analyzer thinks it's used even if I never actually assign extras.

If extras could be assigned with JsonTypeInfo or JsonSerializerContext that could fix this, but probably annoying for consumers?

[vpenades]

UnknownNode is an odd thing, it's rarely used and most probably it will not affect you.

Consider this: SharpGLTF is able to read classes it knows of from json. But what if I load a gltf file that contains an extensions that is unknown to the library? in that case instead of deserializing the data of the extension, it's read as a json node and placed inside the UnknownNode, so it can be serialized back without loosing the data of that unknown extension.

So the only way to actually hit this issue is to load a glTF which contains an unregistered extension.

[xPaw]

Yeah makes sense. (de)serialization is particularly annoying with AOT.

Are you sure DynamicallyAccessedMembers couldn't be sprinkled on the extras field? Or at least UnconditionalSuppressMessage.

[vpenades]

DynamicallyAccessedMembers is not a magic bullet and it only works depending on how you use the method or class you decorated with it.

Anyway, I plan to add some proper AOT unit tests (now that I know how to do it)

[xPaw]

Just for information, my use case is only writing gltf, I never load them.