Skip to content

Docker building failing #54

@garciagenrique

Description

@garciagenrique

See actions output

I see two ways of fixing this:

  • Either returning to the old way of tagging - therefore we won't have the docker images build including the changes of the PR (what imo is not super fundamental as we are reaching the end of the "dev" period),
  • Either implement something like this... what might be a bit more complicated to maintain:
- name: Set image tags
  id: set-tags
  run: |
    if [[ "${{ github.event_name }}" == "pull_request" ]]; then
      echo "tags=${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:dev" >> $GITHUB_ENV
    elif [[ "${{ github.event_name }}" == "release" ]]; then
      echo "tags=${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ github.event.release.tag_name }}" >> $GITHUB_ENV
    elif [[ "${{ github.event_name }}" == "push" && "${{ github.ref_type }}" == "tag" ]]; then
      echo "tags=${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ github.ref }},${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:latest" >> $GITHUB_ENV
    else
      echo "tags=${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:sha-${{ github.sha }},${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:latest" >> $GITHUB_ENV

Listening to your comments @mrzengel and @Soap2G ! :D

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions