The subject field of grants needs to be a string, not an array. #50
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was always in the jwt specification, but was not enforced in the jwt python library until recently. jpadilla/pyjwt#1005 disable verification of the sub field until we're sure new tokens are correct in ~4 months
benbridts
reviewed
Jul 23, 2025
src/delegate.py
Outdated
Comment on lines
111
to
112
| if any(',' in s for s in existing_sub if isinstance(s, str)): | ||
| return bad_request('', 'existing sub chain contains invalid comma') |
There was a problem hiding this comment.
als existing_sub een string is gaat dit problemen geven denk ik
[s for s in "foo"" is ["f", "o", "o"] IIRC
There was a problem hiding this comment.
klopt. ik kijk naar een fix
There was a problem hiding this comment.
misschien iets als
if isinstance(existing_sub, str):
existing_sub = existing_sub.split()
boven de if any
benbridts
reviewed
Jul 23, 2025
src/delegate.py
Outdated
| 'domains': list(domains), | ||
| 'azp': refresh_token['azp'], # Authorized Party | ||
| 'sub': refresh_token.get('sub', []) + [subject], # subject | ||
| 'sub': ', '.join(existing_sub + [subject]), # sub must be string adhering to jwt spec: https://datatracker.ietf.org/doc/html/rfc7519#section-4.1.2 |
There was a problem hiding this comment.
ik zou , zonder spatie gebruiken, is iets eenvoudiger in de split
TomRitserveldt
force-pushed
the
feature/grant-subject-string
branch
from
23a369e to
89ceaef
Compare
TomRitserveldt
force-pushed
the
feature/grant-subject-string
branch
from
f9323ea to
79b9a6e
Compare
benbridts
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was always in the jwt specification, but was not enforced in the jwt python library until recently.
jpadilla/pyjwt#1005
disable verification of the sub field until we're sure new tokens are correct in ~4 months