Use dedicated symbolic color for errors

Author: vslavik

src/colorscheme.cpp

@@ -102,6 +102,7 @@ wxColour ColorScheme::DoGet(Color color, Mode mode)
         case Color::ItemFuzzy:
             return mode == Dark ? sRGB(253, 178, 72) : sRGB(230, 134, 0);
         case Color::ItemError:
+        case Color::ErrorText:
             return sRGB(225, 77, 49);
         case Color::ItemContextFg:
             return mode == Dark ? sRGB(180, 222, 254) : sRGB(70, 109, 137);

src/colorscheme.h

@@ -37,6 +37,8 @@ enum class Color : size_t
 {
     SecondaryLabel,
 
+    ErrorText,
+
     ItemID,
     ItemFuzzy,
     ItemError,

src/customcontrols.cpp

@@ -25,6 +25,7 @@
 
 #include "customcontrols.h"
 
+#include "colorscheme.h"
 #include "concurrency.h"
 #include "errors.h"
 #include "hidpi.h"
@@ -436,7 +437,7 @@ void ActivityIndicator::StopWithError(const wxString& msg)
     m_running = false;
 
     m_spinner->Stop();
-    m_label->SetForegroundColour(*wxRED);
+    m_label->SetForegroundColour(ColorScheme::Get(Color::ErrorText));
     m_label->SetLabel(msg);
     m_label->SetToolTip(msg);
 

src/propertiesdlg.cpp

@@ -56,6 +56,8 @@
 #include <memory>
 
 #include "propertiesdlg.h"
+
+#include "colorscheme.h"
 #include "hidpi.h"
 #include "language.h"
 #include "str_helpers.h"
@@ -880,7 +882,7 @@ void PropertiesDialog::DisableSourcesControls()
 
     auto label = XRCCTRL(*this, "sources_path_label", wxStaticText);
     label->SetLabel(_("Please save the file first. This section cannot be edited until then."));
-    label->SetForegroundColour(*wxRED);
+    label->SetForegroundColour(ColorScheme::Get(Color::ErrorText));
 }