Support automatic app restart with WinSparkle

vslavik · vslavik · commit ff84046759c8 · 2025-10-13T19:38:14.000+02:00
diff --git a/src/app_updates.cpp b/src/app_updates.cpp
@@ -213,8 +213,13 @@ class AppUpdates::impl
 
     static void WinSparkle_Shutdown()
     {
-        auto evt = new wxCommandEvent(wxEVT_COMMAND_MENU_SELECTED, wxID_EXIT);
-        wxGetApp().QueueEvent(evt);
+        // Register for Application Restart so that Restart Manager (used by Inno Setup)
+        // can restart Poedit after it closes us during installation.
+        // Use empty command line ("") and avoid restarts after crash/hang/reboot.
+        RegisterApplicationRestart(L"", RESTART_NO_CRASH | RESTART_NO_HANG | RESTART_NO_REBOOT);
+
+        // Do NOT shut down here! The installer will close us via Restart Manager and
+        // restart after installation completes.
     }
 };
 
diff --git a/win32/poedit.iss b/win32/poedit.iss
@@ -83,6 +83,9 @@ WizardStyle=modern
 AppPublisherURL=https://poedit.net/
 DisableProgramGroupPage=true
 
+RestartApplications=yes
+CloseApplications=yes
+
 #ifdef SIGNTOOL
 SignTool={#SIGNTOOL}
 SignedUninstaller=yes

Original file line number	Diff line number	Diff line change
`@@ -213,8 +213,13 @@ class AppUpdates::impl`
`213`	`213`
`214`	`214`	`static void WinSparkle_Shutdown()`
`215`	`215`	`{`
`216`		`- auto evt = new wxCommandEvent(wxEVT_COMMAND_MENU_SELECTED, wxID_EXIT);`
`217`		`- wxGetApp().QueueEvent(evt);`
	`216`	`+ // Register for Application Restart so that Restart Manager (used by Inno Setup)`
	`217`	`+ // can restart Poedit after it closes us during installation.`
	`218`	`+ // Use empty command line ("") and avoid restarts after crash/hang/reboot.`
	`219`	`+ RegisterApplicationRestart(L"", RESTART_NO_CRASH \| RESTART_NO_HANG \| RESTART_NO_REBOOT);`
	`220`	`+`
	`221`	`+ // Do NOT shut down here! The installer will close us via Restart Manager and`
	`222`	`+ // restart after installation completes.`
`218`	`223`	`}`
`219`	`224`	`};`
`220`	`225`