Merge pull request #357 from hgarrereyn/compare-fix

vstakhov · web-flow · commit 6872c46e528d · 2026-02-03T08:48:50.000Z
Reset length during object copy
diff --git a/src/ucl_util.c b/src/ucl_util.c
@@ -3657,8 +3657,9 @@ ucl_object_copy_internal(const ucl_object_t *other, bool allow_array)
 		}
 
 		if (other->type == UCL_ARRAY || other->type == UCL_OBJECT) {
-			/* reset old value */
+			/* reset old value and length since we will re-add elements below */
 			memset(&new->value, 0, sizeof(new->value));
+			new->len = 0;
 
 			while ((cur = ucl_object_iterate(other, &it, true)) != NULL) {
 				if (other->type == UCL_ARRAY) {

Original file line number	Diff line number	Diff line change
`@@ -3657,8 +3657,9 @@ ucl_object_copy_internal(const ucl_object_t *other, bool allow_array)`
`3657`	`3657`	`}`
`3658`	`3658`
`3659`	`3659`	`if (other->type == UCL_ARRAY \|\| other->type == UCL_OBJECT) {`
`3660`		`- /* reset old value */`
	`3660`	`+ /* reset old value and length since we will re-add elements below */`
`3661`	`3661`	`memset(&new->value, 0, sizeof(new->value));`
	`3662`	`+ new->len = 0;`
`3662`	`3663`
`3663`	`3664`	`while ((cur = ucl_object_iterate(other, &it, true)) != NULL) {`
`3664`	`3665`	`if (other->type == UCL_ARRAY) {`