Skip to content

Hardcoded breakpoint in AppRouter #295

@bgoyarts

Description

@bgoyarts

Describe the bug
It is possible inside a custom theme styles/configs/style.json to specify breakpoints for your theme. However, inside my-account a hardcoded breakpoint is used

<Media query="(max-width: 45em)">
. This conflicts with the generated tachyons file from the supplied config. Result of this is that certain elements disappear in a empty space between breakpoints. An example would be the back button inside the pageHeader.

To Reproduce

  1. Use the following breakpoints for your app styles/config/style.json
    {
      "s": 20
    },
    {
      "ns": {
        "value": 40,
        "minWidth": true
      }
    },
    {
      "m": {
        "value": 40,
        "minWidth": true
      }
    },
    {
      "l": {
        "value": 64,
        "minWidth": true
      }
    },
    {
      "xl": {
        "value": 80,
        "minWidth": true
      }
    }
  ],
  1. Set your screen to a width of 650px
  2. Open the profile page
  3. See that the back button is not rendered

Expected behavior
Back button should be visible

Screenshots
image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions