Skip to content

Commit 10ffab1

Browse files
Review translations added on #144 (#145)
1 parent e979fea commit 10ffab1

6 files changed

Lines changed: 21 additions & 19 deletions

File tree

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
77

88
## [Unreleased]
99

10+
### Fixed
11+
Review EN, ES and PT translations related to customizable loading placeholders and stable recommendation args.
12+
1013
## [2.23.0] - 2026-07-28
1114

1215
### Added

messages/context.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@
1010
"admin/editor.recommendation-shelf.items-context.pdp": "Product Page",
1111
"admin/editor.recommendation-shelf.hidden-paths": "Hidden paths",
1212
"admin/editor.recommendation-shelf.hidden-paths.description": "URL paths where the shelf should not be displayed. Use exact paths (e.g. /checkout/cart) or prefix wildcards with * (e.g. /produto/*).",
13-
"admin/editor.recommendation-shelf.display-loading": "Display loading",
14-
"admin/editor.recommendation-shelf.display-loading.description": "Whether to display a loading placeholder while the shelf is loading.",
13+
"admin/editor.recommendation-shelf.display-loading": "Display loading placeholder",
14+
"admin/editor.recommendation-shelf.display-loading.description": "Shows a loading placeholder while the shelf loads",
1515
"admin/editor.recommendation-shelf.loading-items-per-page": "Loading items per page",
16-
"admin/editor.recommendation-shelf.loading-items-per-page.description": "The number of loading placeholders to display per device type while loading.",
16+
"admin/editor.recommendation-shelf.loading-items-per-page.description": "The number of loading placeholders to display per device type while the shelf is loading",
1717
"admin/editor.recommendation-shelf.loading-items-per-page.desktop": "Desktop",
1818
"admin/editor.recommendation-shelf.loading-items-per-page.tablet": "Tablet",
1919
"admin/editor.recommendation-shelf.loading-items-per-page.phone": "Phone"

messages/en.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@
1010
"admin/editor.recommendation-shelf.items-context.pdp": "Product Page",
1111
"admin/editor.recommendation-shelf.hidden-paths": "Hidden paths",
1212
"admin/editor.recommendation-shelf.hidden-paths.description": "URL paths where the shelf should not be displayed. Use exact paths (e.g. /checkout/cart) or prefix wildcards with * (e.g. /produto/*).",
13-
"admin/editor.recommendation-shelf.display-loading": "Display loading",
14-
"admin/editor.recommendation-shelf.display-loading.description": "Whether to display a loading placeholder while the shelf is loading.",
13+
"admin/editor.recommendation-shelf.display-loading": "Display loading placeholder",
14+
"admin/editor.recommendation-shelf.display-loading.description": "Shows a loading placeholder while the shelf loads",
1515
"admin/editor.recommendation-shelf.loading-items-per-page": "Loading items per page",
16-
"admin/editor.recommendation-shelf.loading-items-per-page.description": "The number of loading placeholders to display per device type while loading.",
16+
"admin/editor.recommendation-shelf.loading-items-per-page.description": "The number of loading placeholders to display per device type while the shelf is loading",
1717
"admin/editor.recommendation-shelf.loading-items-per-page.desktop": "Desktop",
1818
"admin/editor.recommendation-shelf.loading-items-per-page.tablet": "Tablet",
1919
"admin/editor.recommendation-shelf.loading-items-per-page.phone": "Phone"

messages/es.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@
1010
"admin/editor.recommendation-shelf.items-context.pdp": "Página de producto",
1111
"admin/editor.recommendation-shelf.hidden-paths": "Rutas ocultas",
1212
"admin/editor.recommendation-shelf.hidden-paths.description": "Rutas de URL donde la estantería no debe mostrarse. Use rutas exactas (p. ej. /checkout/cart) o comodines de prefijo con * (p. ej. /produto/*).",
13-
"admin/editor.recommendation-shelf.display-loading": "Mostrar carga",
14-
"admin/editor.recommendation-shelf.display-loading.description": "Define si se debe mostrar un placeholder de carga mientras se carga la estantería.",
15-
"admin/editor.recommendation-shelf.loading-items-per-page": "Elementos de carga por página",
16-
"admin/editor.recommendation-shelf.loading-items-per-page.description": "El número de placeholders de carga a mostrar por tipo de dispositivo durante la carga.",
13+
"admin/editor.recommendation-shelf.display-loading": "Mostrar marcador de posición de carga",
14+
"admin/editor.recommendation-shelf.display-loading.description": "Muestra un marcador de posición mientras se carga la estantería de productos",
15+
"admin/editor.recommendation-shelf.loading-items-per-page": "Ítems de carga por página",
16+
"admin/editor.recommendation-shelf.loading-items-per-page.description": "El número de marcadores de posición de carga que se mostrarán por tipo de dispositivo mientras se carga la estantería de productos",
1717
"admin/editor.recommendation-shelf.loading-items-per-page.desktop": "Escritorio",
18-
"admin/editor.recommendation-shelf.loading-items-per-page.tablet": "Tableta",
18+
"admin/editor.recommendation-shelf.loading-items-per-page.tablet": "Tablet",
1919
"admin/editor.recommendation-shelf.loading-items-per-page.phone": "Teléfono"
2020
}

messages/pt.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@
1010
"admin/editor.recommendation-shelf.items-context.pdp": "Página de Produto",
1111
"admin/editor.recommendation-shelf.hidden-paths": "Caminhos ocultos",
1212
"admin/editor.recommendation-shelf.hidden-paths.description": "Caminhos de URL onde a vitrine não deve ser exibida. Use caminhos exatos (ex.: /checkout/cart) ou curingas de prefixo com * (ex.: /produto/*).",
13-
"admin/editor.recommendation-shelf.display-loading": "Exibir carregamento",
14-
"admin/editor.recommendation-shelf.display-loading.description": "Define se um placeholder de carregamento deve ser exibido enquanto a vitrine é carregada.",
13+
"admin/editor.recommendation-shelf.display-loading": "Exibir placeholder de carregamento",
14+
"admin/editor.recommendation-shelf.display-loading.description": "Mostra um placeholder de carregamento enquanto a prateleira carrega",
1515
"admin/editor.recommendation-shelf.loading-items-per-page": "Itens de carregamento por página",
16-
"admin/editor.recommendation-shelf.loading-items-per-page.description": "O número de placeholders de carregamento a exibir por tipo de dispositivo durante o carregamento.",
17-
"admin/editor.recommendation-shelf.loading-items-per-page.desktop": "Desktop",
16+
"admin/editor.recommendation-shelf.loading-items-per-page.description": "O número de placeholders de carregamento a serem exibidos por tipo de dispositivo enquanto a prateleira está carregando",
17+
"admin/editor.recommendation-shelf.loading-items-per-page.desktop": "Computador",
1818
"admin/editor.recommendation-shelf.loading-items-per-page.tablet": "Tablet",
1919
"admin/editor.recommendation-shelf.loading-items-per-page.phone": "Celular"
2020
}

react/RecommendationShelf.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,11 @@ defineMessages({
5656
},
5757
displayLoading: {
5858
id: 'admin/editor.recommendation-shelf.display-loading',
59-
defaultMessage: 'Display loading',
59+
defaultMessage: 'Display loading placeholder',
6060
},
6161
displayLoadingDescription: {
6262
id: 'admin/editor.recommendation-shelf.display-loading.description',
63-
defaultMessage:
64-
'Whether to display a loading placeholder while the shelf is loading.',
63+
defaultMessage: 'Shows a loading placeholder while the shelf loads',
6564
},
6665
loadingItemsPerPage: {
6766
id: 'admin/editor.recommendation-shelf.loading-items-per-page',
@@ -70,7 +69,7 @@ defineMessages({
7069
loadingItemsPerPageDescription: {
7170
id: 'admin/editor.recommendation-shelf.loading-items-per-page.description',
7271
defaultMessage:
73-
'The number of loading placeholders to display per device type while loading.',
72+
'The number of loading placeholders to display per device type while the shelf is loading',
7473
},
7574
loadingItemsPerPageDesktop: {
7675
id: 'admin/editor.recommendation-shelf.loading-items-per-page.desktop',

0 commit comments

Comments
 (0)