Skip to content

Commit a202a44

Browse files
committed
Remove atob dep
1 parent b932ad3 commit a202a44

File tree

4 files changed

+6
-17
lines changed

4 files changed

+6
-17
lines changed

node/directives/withSegment.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { defaultFieldResolver, GraphQLField } from 'graphql'
22
import { SchemaDirectiveVisitor } from 'graphql-tools'
3-
import atob from 'atob'
43

54
/**
65
* Warning: we stopped using the segment client to decode the segment token for us because it added unnecessary overhead for now.
@@ -12,11 +11,11 @@ export class WithSegment extends SchemaDirectiveVisitor {
1211
field.resolve = async (root, args, ctx: Context, info) => {
1312
const {
1413
vtex: { segmentToken },
15-
clients: {segment}
14+
clients: { segment },
1615
} = ctx
1716
ctx.vtex.segment = segmentToken
18-
? JSON.parse(atob(segmentToken))
19-
: (await segment.getSegment())
17+
? JSON.parse(Buffer.from(segmentToken, 'base64').toString())
18+
: await segment.getSegment()
2019
return resolve(root, args, ctx, info)
2120
}
2221
}

node/package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
},
77
"dependencies": {
88
"@gocommerce/utils": "^0.6.11",
9-
"atob": "^2.1.2",
109
"camelcase": "^5.0.0",
1110
"co-body": "^6.2.0",
1211
"cookie": "^0.3.1",
@@ -18,7 +17,6 @@
1817
"vtex.search-graphql": "http://vtex.vtexassets.com/_v/public/typings/v1/[email protected]/public"
1918
},
2019
"devDependencies": {
21-
"@types/atob": "^2.1.2",
2220
"@types/camelcase": "^4.1.0",
2321
"@types/co-body": "^6.1.3",
2422
"@types/cookie": "^0.4.1",

node/services/product.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,9 @@ async function fetchProductFromIntsch(
7777
// Parse vtexSegment if available to extract locale and salesChannel
7878
if (vtexSegment) {
7979
try {
80-
const segmentData: SegmentData = JSON.parse(atob(vtexSegment))
80+
const segmentData: SegmentData = JSON.parse(
81+
Buffer.from(vtexSegment, 'base64').toString()
82+
)
8183

8284
// Use segment's salesChannel if available, otherwise use the provided one
8385
if (segmentData.channel) {

node/yarn.lock

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1034,11 +1034,6 @@
10341034
dependencies:
10351035
"@types/node" "*"
10361036

1037-
"@types/atob@^2.1.2":
1038-
version "2.1.2"
1039-
resolved "https://registry.yarnpkg.com/@types/atob/-/atob-2.1.2.tgz#157eb0cc46264a8c55f2273a836c7a1a644fb820"
1040-
integrity sha512-8GAYQ1jDRUQkSpHzJUqXwAkYFOxuWAOGLhIR4aPd/Y/yL12Q/9m7LsKpHKlfKdNE/362Hc9wPI1Yh6opDfxVJg==
1041-
10421037
"@types/babel__core@^7.1.14":
10431038
version "7.20.5"
10441039
resolved "https://registry.yarnpkg.com/@types/babel__core/-/babel__core-7.20.5.tgz#3df15f27ba85319caa07ba08d0721889bb39c017"
@@ -1649,11 +1644,6 @@ asynckit@^0.4.0:
16491644
resolved "https://registry.yarnpkg.com/asynckit/-/asynckit-0.4.0.tgz#c79ed97f7f34cb8f2ba1bc9790bcc366474b4b79"
16501645
integrity sha512-Oei9OH4tRh0YqU3GxhX79dM/mwVgvbZJaSNaRk+bshkj0S5cfHcgYakreBjrHwatXKbz+IoIdYLxrKim2MjW0Q==
16511646

1652-
atob@^2.1.2:
1653-
version "2.1.2"
1654-
resolved "https://registry.yarnpkg.com/atob/-/atob-2.1.2.tgz#6d9517eb9e030d2436666651e86bd9f6f13533c9"
1655-
integrity sha512-Wm6ukoaOGJi/73p/cl2GvLjTI5JM1k/O14isD73YML8StrH/7/lRFgmg8nICZgD3bZZvjwCGxtMOD3wWNAu8cg==
1656-
16571647
axios-retry@^3.1.2:
16581648
version "3.1.2"
16591649
resolved "https://registry.yarnpkg.com/axios-retry/-/axios-retry-3.1.2.tgz#4f4dcbefb0b434e22b72bd5e28a027d77b8a3458"

0 commit comments

Comments
 (0)