url validator not working properly

[nikosalexakis]

Hi,

I would like to report a bug.
The url validator doesn't accept valid urls with localhost or an IP
and it accepts invalid urls (with text before a valid url)
i.e.
"http://localhost/index.html" --> INVALID
"http://123.1.2.3/index.html" --> INVALID
"sometexthttp://sample.com/index.html" --> VALID

You can find a example here:
https://jsfiddle.net/0mg1v81e/2086/

[zoul0813]

@nikosalexakis it looks like the url validator is quite broken ...

This validator should probably be extended to support some validation rules, with some sane defaults ...

for example, allowing you to validate against a specific URL Scheme (http, https, ftp, sms, tel, mailto, etc). This can be done by adding a validation rule to the field, such as urlSchemes: ['http', 'https', 'tel', 'sms'], with a sane default of ['http', 'https'] to default to generic web addresses. It also should not require the URL to contain a minimum number of domains (http://example.com, vs http://localhost). However, this limit can be configured as well with something like urlLabels: 2 (requiring something like example.com, and invalidating localhost). We can also allow/disallow IPv4/6 addresses, etc ... the current validator is a bit too basic.

I recommend using the regex validator in the mean time, and using a custom regex or copy one of the more well-known URL validator regex's ...

I like this one, ^(http|https):\/\/[^ "]+ as it just ensures the string contains "valid characters" for a URL, and does not limit them in any way ...

[nikosalexakis]

Thank you @zoul0813 for your recommendations.

I will use a custom validator with a regex as you mentioned.