Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactivity): prevent overwriting next property during batch processing #12075

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

jh-leong
Copy link
Member

close #12072

Copy link

github-actions bot commented Sep 29, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB (+74 B) 38.1 kB (+27 B) 34.3 kB (+14 B)
vue.global.prod.js 160 kB (+70 B) 58 kB (+28 B) 51.5 kB (+41 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49.1 kB (+74 B) 18.9 kB (+30 B) 17.3 kB (+39 B)
createApp 55.7 kB (+69 B) 21.4 kB (+25 B) 19.6 kB (-25 B)
createSSRApp 59.7 kB (+69 B) 23.2 kB (+26 B) 21.1 kB (+82 B)
defineCustomElement 60.5 kB (+71 B) 23 kB (+22 B) 20.9 kB (+15 B)
overall 69.4 kB (+69 B) 26.5 kB (+28 B) 24.1 kB (+10 B)

Copy link

pkg-pr-new bot commented Sep 29, 2024

Open in Stackblitz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12075

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12075

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12075

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12075

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12075

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12075

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12075

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12075

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12075

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12075

vue

pnpm add https://pkg.pr.new/vue@12075

commit: 46c96ba

@jh-leong
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Sep 29, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros failure failure
vuetify success success
vueuse success failure
vue-simple-compiler success success

@jh-leong jh-leong marked this pull request as draft September 29, 2024 11:53
@jh-leong jh-leong marked this pull request as ready for review September 29, 2024 12:06
@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: reactivity ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. labels Sep 29, 2024
@jh-leong
Copy link
Member Author

/ecosystem-ci run

@vue-bot

This comment was marked as outdated.

@yyx990803 yyx990803 merged commit d3f5e6e into vuejs:main Oct 3, 2024
13 checks passed
@vue-bot
Copy link
Contributor

vue-bot commented Oct 3, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant failure success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@jh-leong jh-leong deleted the fix/12072 branch October 4, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. ready to merge The PR is ready to be merged. scope: reactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync watcher triggering computed breaks subsequent updates
5 participants