Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): retain union type narrowing with defaults applied #12108

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(types): retain union type narrowing with defaults applied #12108

wants to merge 2 commits into from
+34 −15

Conversation

edison1105
Copy link
Member

close #12106

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB 38.1 kB 34.2 kB
vue.global.prod.js 160 kB 58 kB 51.5 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49.1 kB 18.9 kB 17.3 kB
createApp 55.7 kB 21.4 kB 19.6 kB
createSSRApp 59.7 kB 23.1 kB 21 kB
defineCustomElement 60.4 kB 23 kB 20.9 kB
overall 69.4 kB 26.5 kB 24.1 kB

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 4, 2024 •
edited
Loading

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12108

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12108

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12108

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12108

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12108

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12108

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12108

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12108

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12108

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12108

vue

pnpm add https://pkg.pr.new/vue@12108

commit: e88722a

@edison1105 edison1105 changed the title fix(types): retain union type narrowing in PropsWithDefaults with defaults applied fix(types): retain union type narrowing with defaults applied Oct 4, 2024
@edison1105 edison1105 added the ready to merge The PR is ready to be merged. label Oct 4, 2024
@darkbasic
Copy link

Could you please check if it somehow helps with #12110
Thanks

@edison1105
Copy link
Member Author

Could you please check if it somehow helps with #12110 Thanks

I think it is related to language-tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jh-leong jh-leong jh-leong approved these changes

Assignees
No one assigned
Labels
ready to merge The PR is ready to be merged. scope: types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discriminated Union will not work if default value is specified
3 participants
@edison1105 @darkbasic @jh-leong