Skip to content

Commit 1e84ae7

Browse files
committed
combine vBindShorthand.ts and types.ts
1 parent 962f1b4 commit 1e84ae7

File tree

7 files changed

+20
-20
lines changed

7 files changed

+20
-20
lines changed

packages/language-core/lib/codegen/template/vBindShorthand.ts packages/language-core/lib/codegen/inlayHints.ts

+12-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,16 @@
11
import type * as CompilerDOM from '@vue/compiler-dom';
2-
import type { InlayHintInfo } from "../types";
32

4-
export function generateVBindShorthandInlayHint(loc: CompilerDOM.SourceLocation, variableName: string): InlayHintInfo {
3+
export interface InlayHintInfo {
4+
blockName: string;
5+
offset: number;
6+
setting: string;
7+
label: string;
8+
tooltip?: string;
9+
paddingRight?: boolean;
10+
paddingLeft?: boolean;
11+
}
12+
13+
export function createVBindShorthandInlayHintInfo(loc: CompilerDOM.SourceLocation, variableName: string): InlayHintInfo {
514
return {
615
blockName: 'template',
716
offset: loc.end.offset,
@@ -13,4 +22,4 @@ export function generateVBindShorthandInlayHint(loc: CompilerDOM.SourceLocation,
1322
'[More info](https://github.com/vuejs/core/pull/9451)',
1423
].join('\n\n'),
1524
};
16-
};
25+
}

packages/language-core/lib/codegen/script/context.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { InlayHintInfo } from '../types';
1+
import { InlayHintInfo } from '../inlayHints';
22
import { getLocalTypesGenerator } from '../localTypes';
33
import type { ScriptCodegenOptions } from './index';
44

packages/language-core/lib/codegen/template/context.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import type * as CompilerDOM from '@vue/compiler-dom';
22
import type { Code, VueCodeInformation } from '../../types';
33
import { endOfLine, newLine, wrapWith } from '../common';
44
import type { TemplateCodegenOptions } from './index';
5-
import { InlayHintInfo } from '../types';
5+
import { InlayHintInfo } from '../inlayHints';
66

77
const _codeFeatures = {
88
all: {

packages/language-core/lib/codegen/template/element.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import { generateInterpolation } from './interpolation';
1515
import { generatePropertyAccess } from './propertyAccess';
1616
import { generateTemplateChild } from './templateChild';
1717
import { generateObjectProperty } from './objectProperty';
18-
import { generateVBindShorthandInlayHint } from './vBindShorthand';
18+
import { createVBindShorthandInlayHintInfo } from '../inlayHints';
1919
import { getNodeText } from '../../parsers/scriptSetupRanges';
2020

2121
const colonReg = /:/g;
@@ -115,7 +115,7 @@ export function* generateComponent(
115115
}
116116
else if (dynamicTagInfo) {
117117
if (dynamicTagInfo.isComponentIsShorthand) {
118-
ctx.inlayHints.push(generateVBindShorthandInlayHint(dynamicTagInfo.exp.loc, 'is'));
118+
ctx.inlayHints.push(createVBindShorthandInlayHintInfo(dynamicTagInfo.exp.loc, 'is'));
119119
}
120120
yield `const ${var_originalComponent} = (`;
121121
yield* generateInterpolation(

packages/language-core/lib/codegen/template/elementProps.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import { generateEventArg, generateEventExpression } from './elementEvents';
1111
import type { TemplateCodegenOptions } from './index';
1212
import { generateInterpolation } from './interpolation';
1313
import { generateObjectProperty } from './objectProperty';
14-
import { generateVBindShorthandInlayHint } from './vBindShorthand';
14+
import { createVBindShorthandInlayHintInfo } from '../inlayHints';
1515

1616
export function* generateElementProps(
1717
options: TemplateCodegenOptions,
@@ -335,7 +335,7 @@ function* generatePropExp(
335335
features
336336
);
337337
if (enableCodeFeatures) {
338-
ctx.inlayHints.push(generateVBindShorthandInlayHint(prop.loc, propVariableName));
338+
ctx.inlayHints.push(createVBindShorthandInlayHintInfo(prop.loc, propVariableName));
339339
}
340340
}
341341
}

packages/language-core/lib/codegen/template/slotOutlet.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { generateElementChildren } from './elementChildren';
66
import { generateElementProps } from './elementProps';
77
import type { TemplateCodegenOptions } from './index';
88
import { generateInterpolation } from './interpolation';
9-
import { generateVBindShorthandInlayHint } from './vBindShorthand';
9+
import { createVBindShorthandInlayHintInfo } from '../inlayHints';
1010

1111
export function* generateSlotOutlet(
1212
options: TemplateCodegenOptions,
@@ -83,7 +83,7 @@ export function* generateSlotOutlet(
8383
) {
8484
const isShortHand = nameProp.arg?.loc.start.offset === nameProp.exp.loc.start.offset;
8585
if (isShortHand) {
86-
ctx.inlayHints.push(generateVBindShorthandInlayHint(nameProp.exp.loc, 'name'));
86+
ctx.inlayHints.push(createVBindShorthandInlayHintInfo(nameProp.exp.loc, 'name'));
8787
}
8888
const slotExpVar = ctx.getInternalVariable();
8989
yield `var ${slotExpVar} = `;

packages/language-core/lib/codegen/types.ts

-9
This file was deleted.

0 commit comments

Comments
 (0)