From 9e967bfda7e670a96773c63e75427d1a7c1ae7d7 Mon Sep 17 00:00:00 2001 From: Johnson Chu Date: Sat, 8 Mar 2025 01:01:36 +0800 Subject: [PATCH] fix(language-server): rename requestForwardingCommand to tsserverRequestCommand --- extensions/vscode/src/languageClient.ts | 2 +- extensions/vscode/src/nodeClientMain.ts | 2 +- packages/language-server/lib/types.ts | 2 +- packages/language-server/node.ts | 10 +++++----- packages/language-server/tests/server.ts | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/extensions/vscode/src/languageClient.ts b/extensions/vscode/src/languageClient.ts index ebf2783841..19262929ed 100644 --- a/extensions/vscode/src/languageClient.ts +++ b/extensions/vscode/src/languageClient.ts @@ -108,7 +108,7 @@ async function getInitializationOptions(context: vscode.ExtensionContext): Promi return { typescript: { tsdk: (await lsp.getTsdk(context))!.tsdk, - requestForwardingCommand: 'forwardingTsRequest', + tsserverRequestCommand: 'tsserverRequest', }, }; } diff --git a/extensions/vscode/src/nodeClientMain.ts b/extensions/vscode/src/nodeClientMain.ts index 4b0dfb1499..36f3d92551 100644 --- a/extensions/vscode/src/nodeClientMain.ts +++ b/extensions/vscode/src/nodeClientMain.ts @@ -86,7 +86,7 @@ export const { activate, deactivate } = defineExtension(async () => { updateProviders(client); - client.onRequest('forwardingTsRequest', async ([command, args]) => { + client.onRequest('tsserverRequest', async ([command, args]) => { const tsserver = (globalThis as any).__TSSERVER__?.semantic; if (!tsserver) { return; diff --git a/packages/language-server/lib/types.ts b/packages/language-server/lib/types.ts index 47cba24eca..1a64a0ef80 100644 --- a/packages/language-server/lib/types.ts +++ b/packages/language-server/lib/types.ts @@ -1,7 +1,7 @@ export type VueInitializationOptions = { typescript: { tsdk: string; - requestForwardingCommand?: string; + tsserverRequestCommand?: string; }; }; diff --git a/packages/language-server/node.ts b/packages/language-server/node.ts index f35c5cd91e..f49aea5c6a 100644 --- a/packages/language-server/node.ts +++ b/packages/language-server/node.ts @@ -18,8 +18,8 @@ connection.onInitialize(params => { if (!options.typescript?.tsdk) { throw new Error('typescript.tsdk is required'); } - if (!options.typescript?.requestForwardingCommand) { - connection.console.warn('typescript.requestForwardingCommand is required since >= 3.0 for complete TS features'); + if (!options.typescript?.tsserverRequestCommand) { + connection.console.warn('typescript.tsserverRequestCommand is required since >= 3.0 for complete TS features'); } const { typescript: ts } = loadTsdkByPath(options.typescript.tsdk, params.locale); @@ -42,7 +42,7 @@ connection.onInitialize(params => { { setup() { }, async getLanguageService(uri) { - if (uri.scheme === 'file' && options.typescript.requestForwardingCommand) { + if (uri.scheme === 'file' && options.typescript.tsserverRequestCommand) { const fileName = uri.fsPath.replace(/\\/g, '/'); const projectInfo = await sendTsRequest( ts.server.protocol.CommandTypes.ProjectInfo, @@ -80,7 +80,7 @@ connection.onInitialize(params => { simpleLs = undefined; }, }, - getHybridModeLanguageServicePlugins(ts, options.typescript.requestForwardingCommand ? { + getHybridModeLanguageServicePlugins(ts, options.typescript.tsserverRequestCommand ? { collectExtractProps(...args) { return sendTsRequest('vue:collectExtractProps', args); }, @@ -115,7 +115,7 @@ connection.onInitialize(params => { ); function sendTsRequest(command: string, args: any): Promise { - return connection.sendRequest(options.typescript.requestForwardingCommand!, [command, args]); + return connection.sendRequest(options.typescript.tsserverRequestCommand!, [command, args]); } function createLs(server: LanguageServer, tsconfig: string | undefined) { diff --git a/packages/language-server/tests/server.ts b/packages/language-server/tests/server.ts index b31ad558ce..2611e54a2a 100644 --- a/packages/language-server/tests/server.ts +++ b/packages/language-server/tests/server.ts @@ -44,7 +44,7 @@ export async function getLanguageServer(): Promise<{ return null; }); }); - serverHandle.connection.onRequest('forwardingTsRequest', async ([command, args]) => { + serverHandle.connection.onRequest('tsserverRequest', async ([command, args]) => { const res = await tsserver.message({ seq: seq++, command: command, @@ -58,7 +58,7 @@ export async function getLanguageServer(): Promise<{ { typescript: { tsdk: path.dirname(require.resolve('typescript/lib/typescript.js')), - requestForwardingCommand: 'forwardingTsRequest', + tsserverRequestCommand: 'tsserverRequest', }, } satisfies VueInitializationOptions, {