fix(language-core): detect duplicate event listeners across name formats (#6094)

Co-authored-by: KazariEX <zinkawaii@qq.com>

Author: whysopaul

packages/language-core/lib/codegen/template/elementEvents.ts

@@ -19,7 +19,15 @@ export function* generateElementEvents(
 	getCtxVar: () => string,
 	getPropsVar: () => string,
 ): Generator<Code> {
-	let emitsVar: string | undefined;
+	const definitions: {
+		prop: CompilerDOM.DirectiveNode;
+		source: string;
+		offset: number | undefined;
+		emitPrefix: string;
+		propPrefix: string;
+		propName: string;
+		emitName: string;
+	}[] = [];
 
 	for (const prop of node.props) {
 		if (
@@ -32,13 +40,8 @@ export function* generateElementEvents(
 					&& (!prop.arg || prop.arg.type === CompilerDOM.NodeTypes.SIMPLE_EXPRESSION && prop.arg.isStatic)
 			)
 		) {
-			if (!emitsVar) {
-				emitsVar = ctx.getInternalVariable();
-				yield `let ${emitsVar}!: ${names.ResolveEmits}<typeof ${componentOriginalVar}, typeof ${getCtxVar()}.emit>${endOfLine}`;
-			}
-
 			let source = prop.arg?.loc.source ?? 'model-value';
-			let start = prop.arg?.loc.start.offset;
+			let offset = prop.arg?.loc.start.offset;
 			let propPrefix = 'on-';
 			let emitPrefix = '';
 			if (prop.name === 'model') {
@@ -47,33 +50,61 @@ export function* generateElementEvents(
 			}
 			else if (source.startsWith('vue:')) {
 				source = source.slice('vue:'.length);
-				start = start! + 'vue:'.length;
+				offset = offset! + 'vue:'.length;
 				propPrefix = 'onVnode-';
 				emitPrefix = 'vnode-';
 			}
 			const propName = camelize(propPrefix + source);
 			const emitName = emitPrefix + source;
-			const camelizedEmitName = camelize(emitName);
 
-			yield `const ${ctx.getInternalVariable()}: ${names.NormalizeComponentEvent}<typeof ${getPropsVar()}, typeof ${emitsVar}, '${propName}', '${emitName}', '${camelizedEmitName}'> = (${newLine}`;
-			if (prop.name === 'on') {
-				yield `{ `;
-				yield* generateEventArg(options, source, start!, emitPrefix.slice(0, -1), codeFeatures.navigation);
-				yield `: {} as any } as typeof ${emitsVar},${newLine}`;
-			}
-			yield `{ `;
-			if (prop.name === 'on') {
-				yield* generateEventArg(options, source, start!, propPrefix.slice(0, -1));
-				yield `: `;
-				yield* generateEventExpression(options, ctx, prop);
-			}
-			else {
-				yield `'${propName}': `;
-				yield* generateModelEventExpression(options, ctx, prop);
-			}
-			yield `})${endOfLine}`;
+			definitions.push({
+				prop,
+				source,
+				offset,
+				emitPrefix,
+				propPrefix,
+				propName,
+				emitName,
+			});
+		}
+	}
+
+	if (!definitions.length) {
+		return;
+	}
+
+	const emitsVar = ctx.getInternalVariable();
+	yield `let ${emitsVar}!: ${names.ResolveEmits}<typeof ${componentOriginalVar}, typeof ${getCtxVar()}.emit>${endOfLine}`;
+
+	yield `const ${ctx.getInternalVariable()}: `;
+	for (let i = 0; i < definitions.length; i++) {
+		const { propName, emitName } = definitions[i]!;
+		if (i > 0) {
+			yield ` & `;
+		}
+		yield `${names.NormalizeComponentEvent}<typeof ${getPropsVar()}, typeof ${emitsVar}, '${propName}', '${emitName}', '${
+			camelize(emitName)
+		}'>`;
+	}
+	yield ` = {${newLine}`;
+	for (const { prop, source, offset, emitPrefix, propPrefix, propName } of definitions) {
+		if (prop.name === 'on') {
+			yield `...{ `;
+			yield* generateEventArg(options, source, offset!, emitPrefix.slice(0, -1), codeFeatures.navigation);
+			yield `: {} as any } as typeof ${emitsVar},${newLine}`;
+		}
+		if (prop.name === 'on') {
+			yield* generateEventArg(options, source, offset!, propPrefix.slice(0, -1));
+			yield `: `;
+			yield* generateEventExpression(options, ctx, prop);
+		}
+		else {
+			yield `'${propName}': `;
+			yield* generateModelEventExpression(options, ctx, prop);
 		}
+		yield `,${newLine}`;
 	}
+	yield `}${endOfLine}`;
 }
 
 export function* generateEventArg(

test-workspace/tsc/#6094/main.vue

@@ -0,0 +1,10 @@
+<script setup lang="ts">
+declare function Comp(props: {
+	onFooBar?: () => void;
+}): void;
+</script>
+
+<template>
+	<!-- @vue-expect-error -->
+	<Comp @foo-bar="void 0" @fooBar="void 0" />
+</template>

test-workspace/tsc/#6094/tsconfig.json

@@ -0,0 +1,4 @@
+{
+	"extends": "../../tsconfig.base.json",
+	"include": ["**/*"]
+}

test-workspace/tsc/tsconfig.json

@@ -520,6 +520,9 @@
 		{
 			"path": "./#6084/tsconfig.json"
 		},
+		{
+			"path": "./#6094/tsconfig.json"
+		},
 		{
 			"path": "./#625/tsconfig.json"
 		},