fix(store): keep original refs with $reset

Fix #593
vuejs · Jul 30, 2021 · a7dadff · a7dadff
1 parent b242f42
commit a7dadff
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/__tests__/store.spec.ts b/__tests__/store.spec.ts
@@ -93,6 +93,9 @@ describe('Store', () => {
         a: { b: 'string' },
       },
     })
+
+    // https://github.com/posva/pinia/issues/593
+    expect(store.nested.foo).toBe('bar')
   })
 
   it('can create an empty state if no state option is provided', () => {

diff --git a/src/store.ts b/src/store.ts
@@ -95,19 +95,15 @@ function createOptionsStore<
   hot?: boolean
 ): Store<Id, S, G, A> {
   const { state, actions, getters } = options
-  function $reset() {
-    pinia.state.value[id] = state ? state() : {}
-  }
 
   const initialState: StateTree | undefined = pinia.state.value[id]
 
   let store: Store<Id, S, G, A>
 
   function setup() {
     if (!initialState && (!__DEV__ || !hot)) {
-      $reset()
+      pinia.state.value[id] = state ? state() : {}
     }
-    // pinia.state.value[id] = state ? state() : {}
 
     // avoid creating a state in pinia.state.value
     const localState =
@@ -135,7 +131,13 @@ function createOptionsStore<
 
   store = createSetupStore(id, setup, options, pinia, hot)
 
-  store.$reset = $reset
+  store.$reset = function $reset() {
+    const newState = state ? state() : {}
+    // we use a patch to group all changes into one single subscription
+    this.$patch(($state) => {
+      assign($state, newState)
+    })
+  }
 
   return store as any
 }