feat: update devtools-api

posva · posva · commit ca266868c5c5 · 2021-12-20T16:09:49.000+01:00
diff --git a/packages/pinia/package.json b/packages/pinia/package.json
@@ -76,7 +76,7 @@
     "vue2": "npm:vue@2"
   },
   "dependencies": {
-    "@vue/devtools-api": "^6.0.0-beta.20.1",
+    "@vue/devtools-api": "^6.0.0-beta.21",
     "vue-demi": "*"
   },
   "peerDependencies": {
diff --git a/packages/pinia/src/createPinia.ts b/packages/pinia/src/createPinia.ts
@@ -28,7 +28,6 @@ export function createPinia(): Pinia {
         app.config.globalProperties.$pinia = pinia
         /* istanbul ignore else */
         if (__DEV__ && IS_CLIENT) {
-          // @ts-expect-error: weird type in devtools api
           registerPiniaDevtools(app, pinia)
         }
         toBeInstalled.forEach((plugin) => _p.push(plugin))
diff --git a/packages/pinia/src/devtools/plugin.ts b/packages/pinia/src/devtools/plugin.ts
@@ -533,7 +533,6 @@ export function devtoolsPlugin<
   }
 
   addStoreToDevtools(
-    // @ts-expect-error: should be of type App from vue
     app,
     // FIXME: is there a way to allow the assignment from Store<Id, S, G, A> to StoreGeneric?
     store as StoreGeneric
diff --git a/packages/pinia/src/vue2-plugin.ts b/packages/pinia/src/vue2-plugin.ts
@@ -23,7 +23,7 @@ import { Pinia, piniaSymbol, setActivePinia } from './rootStore'
  * })
  * ```
  *
- * @param _Vue
+ * @param _Vue - `Vue` imported from 'vue'.
  */
 export const PiniaVuePlugin: Plugin = function (_Vue) {
   // Equivalent of
@@ -57,7 +57,6 @@ export const PiniaVuePlugin: Plugin = function (_Vue) {
           // installing pinia's plugin
           setActivePinia(pinia)
           if (__DEV__) {
-            // @ts-expect-error: weird type in devtools api
             registerPiniaDevtools(pinia._a, pinia)
           }
         }
diff --git a/packages/playground/tsconfig.json b/packages/playground/tsconfig.json
@@ -9,7 +9,8 @@
     "sourceMap": true,
     "resolveJsonModule": true,
     "esModuleInterop": true,
-    "lib": ["esnext", "dom"]
+    "lib": ["esnext", "dom"],
+    "types": ["vite/client"]
   }
   // "include": ["src/**/*.ts", "src/**/*.d.ts", "src/**/*.tsx", "src/**/*.vue"]
 }
diff --git a/tsconfig.json b/tsconfig.json
@@ -36,6 +36,6 @@
     "removeComments": false,
     "jsx": "preserve",
     "lib": ["esnext", "dom"],
-    "types": ["jest", "node"]
+    "types": ["jest", "node", "vite/client"]
   }
 }
diff --git a/yarn.lock b/yarn.lock
@@ -2193,11 +2193,16 @@
     "@vue/compiler-dom" "3.2.26"
     "@vue/shared" "3.2.26"
 
-"@vue/devtools-api@^6.0.0-beta.18", "@vue/devtools-api@^6.0.0-beta.20.1":
+"@vue/devtools-api@^6.0.0-beta.18":
   version "6.0.0-beta.20.1"
   resolved "https://registry.yarnpkg.com/@vue/devtools-api/-/devtools-api-6.0.0-beta.20.1.tgz#5b499647e929c35baf2a66a399578f9aa4601142"
   integrity sha512-R2rfiRY+kZugzWh9ZyITaovx+jpU4vgivAEAiz80kvh3yviiTU3CBuGuyWpSwGz9/C7TkSWVM/FtQRGlZ16n8Q==
 
+"@vue/devtools-api@^6.0.0-beta.21":
+  version "6.0.0-beta.21"
+  resolved "https://registry.yarnpkg.com/@vue/devtools-api/-/devtools-api-6.0.0-beta.21.tgz#74d78f15d61e7da31b3ed918e955c42aa94fbf6d"
+  integrity sha512-97C2evr7bKxtXEmgMiSuidKyW0fjdGJ6UBIAnUIH7vu5AHgp15u5h4USkeT1qj/jxl0wyOOfcnvevPapyDGAmQ==
+
 "@vue/reactivity-transform@3.2.26":
   version "3.2.26"
   resolved "https://registry.yarnpkg.com/@vue/reactivity-transform/-/reactivity-transform-3.2.26.tgz#6d8f20a4aa2d19728f25de99962addbe7c4d03e9"

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,6 @@ export function createPinia(): Pinia {`
`28`	`28`	`app.config.globalProperties.$pinia = pinia`
`29`	`29`	`/* istanbul ignore else */`
`30`	`30`	`if (__DEV__ && IS_CLIENT) {`
`31`		`- // @ts-expect-error: weird type in devtools api`
`32`	`31`	`registerPiniaDevtools(app, pinia)`
`33`	`32`	`}`
`34`	`33`	`toBeInstalled.forEach((plugin) => _p.push(plugin))`
Original file line number	Diff line number	Diff line change
`@@ -533,7 +533,6 @@ export function devtoolsPlugin<`
`533`	`533`	`}`
`534`	`534`
`535`	`535`	`addStoreToDevtools(`
`536`		`- // @ts-expect-error: should be of type App from vue`
`537`	`536`	`app,`
`538`	`537`	`// FIXME: is there a way to allow the assignment from Store<Id, S, G, A> to StoreGeneric?`
`539`	`538`	`store as StoreGeneric`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ import { Pinia, piniaSymbol, setActivePinia } from './rootStore'`
`23`	`23`	`* })`
`24`	`24`	* ```
`25`	`25`	`*`
`26`		`- * @param _Vue`
	`26`	+ * @param _Vue - `Vue` imported from 'vue'.
`27`	`27`	`*/`
`28`	`28`	`export const PiniaVuePlugin: Plugin = function (_Vue) {`
`29`	`29`	`// Equivalent of`
`@@ -57,7 +57,6 @@ export const PiniaVuePlugin: Plugin = function (_Vue) {`
`57`	`57`	`// installing pinia's plugin`
`58`	`58`	`setActivePinia(pinia)`
`59`	`59`	`if (__DEV__) {`
`60`		`- // @ts-expect-error: weird type in devtools api`
`61`	`60`	`registerPiniaDevtools(pinia._a, pinia)`
`62`	`61`	`}`
`63`	`62`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,8 @@`
`9`	`9`	`"sourceMap": true,`
`10`	`10`	`"resolveJsonModule": true,`
`11`	`11`	`"esModuleInterop": true,`
`12`		`- "lib": ["esnext", "dom"]`
	`12`	`+ "lib": ["esnext", "dom"],`
	`13`	`+ "types": ["vite/client"]`
`13`	`14`	`}`
`14`	`15`	`// "include": ["src/*/.ts", "src/*/.d.ts", "src/*/.tsx", "src/*/.vue"]`
`15`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,6 @@`
`36`	`36`	`"removeComments": false,`
`37`	`37`	`"jsx": "preserve",`
`38`	`38`	`"lib": ["esnext", "dom"],`
`39`		`- "types": ["jest", "node"]`
	`39`	`+ "types": ["jest", "node", "vite/client"]`
`40`	`40`	`}`
`41`	`41`	`}`