fix(experimental): resolve TS errors in resolver/router type hierarchy

Widen parent/aliasOf in ResolverRecord_Base from the narrow union type
to the base interface, allowing router types to narrow them via standard
interface extension instead of incompatible overrides.

Author: posva

packages/router/src/experimental/route-resolver/resolver-fixed.spec.ts

@@ -1,5 +1,8 @@
 import { describe, expect, it } from 'vitest'
-import { createFixedResolver } from './resolver-fixed'
+import {
+  createFixedResolver,
+  type EXPERIMENTAL_ResolverRecord_Matchable,
+} from './resolver-fixed'
 import { NO_MATCH_LOCATION } from './resolver-abstract'
 import {
   EmptyParams,
@@ -1288,7 +1291,7 @@ describe('fixed resolver', () => {
       })
 
       it('original path still resolves normally', () => {
-        const original = {
+        const original: EXPERIMENTAL_ResolverRecord_Matchable = {
           name: 'users',
           path: new MatcherPatternPathStatic('/users'),
         }
@@ -1305,7 +1308,7 @@ describe('fixed resolver', () => {
       })
 
       it('matched array entry has aliasOf pointing to original', () => {
-        const original = {
+        const original: EXPERIMENTAL_ResolverRecord_Matchable = {
           name: 'users',
           path: new MatcherPatternPathStatic('/users'),
         }
@@ -1366,11 +1369,11 @@ describe('fixed resolver', () => {
       })
 
       it('child alias resolves with parent in matched', () => {
-        const parent = {
+        const parent: EXPERIMENTAL_ResolverRecord_Matchable = {
           name: 'parent',
           path: new MatcherPatternPathStatic('/parent'),
         }
-        const child = {
+        const child: EXPERIMENTAL_ResolverRecord_Matchable = {
           name: 'child',
           path: new MatcherPatternPathStatic('/child'),
           parent,

packages/router/src/experimental/route-resolver/resolver-fixed.ts

@@ -54,14 +54,14 @@ export interface EXPERIMENTAL_ResolverRecord_Base {
    * Parent record. The parent can be a group or a matchable record.
    * It will be included in the `matched` array of a resolved location.
    */
-  parent?: EXPERIMENTAL_ResolverRecord | null // the parent can be matchable or not
+  parent?: EXPERIMENTAL_ResolverRecord_Base | null // the parent can be matchable or not
 
   /**
    * If this record is an alias of another record, this points to the original
    * record. Alias records are not added to the name map and resolve to the
    * original record's name.
    */
-  aliasOf?: EXPERIMENTAL_ResolverRecord | null
+  aliasOf?: EXPERIMENTAL_ResolverRecord_Base | null
 }
 
 /**
@@ -115,7 +115,7 @@ export interface EXPERIMENTAL_ResolverFixed<
 /**
  * Build the `matched` array of a record that includes all parent records from the root to the current one.
  */
-export function buildMatched<T extends EXPERIMENTAL_ResolverRecord>(
+export function buildMatched<T extends EXPERIMENTAL_ResolverRecord_Base>(
   record: T
 ): T[] {
   const matched: T[] = []

packages/router/src/experimental/router.ts

@@ -193,12 +193,6 @@ export interface EXPERIMENTAL_RouteRecord_Base extends EXPERIMENTAL_ResolverReco
    */
   redirect?: RouteRecordRedirectOption
 
-  // TODO:
-  /**
-   * References another record if this record is an alias of it.
-   */
-  aliasOf?: this
-
   // TODO: deprecate, expose utils to compare resolved routes, and document
   // how to create a meta field that does the same
   /**
@@ -224,6 +218,11 @@ export interface EXPERIMENTAL_RouteRecord_Base extends EXPERIMENTAL_ResolverReco
    */
   parent?: EXPERIMENTAL_RouteRecordNormalized | null
 
+  /**
+   * References another record if this record is an alias of it.
+   */
+  aliasOf?: EXPERIMENTAL_RouteRecordNormalized | null
+
   // TODO:
   /**
    * Allow passing down params as props to the component rendered by `router-view`.
@@ -235,12 +234,10 @@ export interface EXPERIMENTAL_RouteRecord_Redirect
   // preserve the values from the type EXPERIMENTAL_ResolverRecord_Matchable
   extends
     Omit<EXPERIMENTAL_RouteRecord_Base, 'name' | 'path'>,
-    EXPERIMENTAL_ResolverRecord_Matchable {
+    Omit<EXPERIMENTAL_ResolverRecord_Matchable, 'parent' | 'aliasOf'> {
   components?: Record<string, RawRouteComponent>
 
   redirect: RouteRecordRedirectOption // must be defined
-
-  parent?: EXPERIMENTAL_RouteRecordNormalized | null // must be redifined because of ResolverRecord_Matchable
 }
 
 export interface EXPERIMENTAL_RouteRecord_Group
@@ -250,22 +247,18 @@ export interface EXPERIMENTAL_RouteRecord_Group
       // preserve the values from the type EXPERIMENTAL_ResolverRecord_Group
       'name' | 'path' | 'query' | 'hash'
     >,
-    EXPERIMENTAL_ResolverRecord_Group {
+    Omit<EXPERIMENTAL_ResolverRecord_Group, 'parent' | 'aliasOf'> {
   components?: Record<string, RawRouteComponent>
-
-  parent?: EXPERIMENTAL_RouteRecordNormalized | null // must be redifined because of ResolverRecord_Matchable
 }
 
 export interface EXPERIMENTAL_RouteRecord_Components
   // preserve the values from the type EXPERIMENTAL_ResolverRecord_Matchable
   extends
     Omit<EXPERIMENTAL_RouteRecord_Base, 'name' | 'path'>,
-    EXPERIMENTAL_ResolverRecord_Matchable {
+    Omit<EXPERIMENTAL_ResolverRecord_Matchable, 'parent' | 'aliasOf'> {
   components: Record<string, RawRouteComponent>
 
   redirect?: never
-
-  parent?: EXPERIMENTAL_RouteRecordNormalized | null // must be redifined because of ResolverRecord_Matchable
 }
 
 export type EXPERIMENTAL_RouteRecord_Matchable =