fix(theme): ensure correct outline state - #2189
Closed
microdev1 wants to merge 1 commit into
Closed
Conversation
brc-dd
force-pushed
the
main
branch
2 times, most recently
from
August 3, 2023 10:20
7ad4a4e to
f0d3082
Compare
brc-dd
force-pushed
the
main
branch
2 times, most recently
from
August 14, 2025 03:45
c5a8428 to
8abbe29
Compare
brc-dd
force-pushed
the
main
branch
2 times, most recently
from
August 20, 2025 14:41
084cf43 to
d3a1567
Compare
brc-dd
force-pushed
the
main
branch
3 times, most recently
from
March 26, 2026 04:26
15a0278 to
09af6c7
Compare
Collaborator
|
This PR is quite old, but I think most of the issue explained is now fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a couple of edge cases in outline:
isAsideEnabledbecomestrueafter being set tofalseand the content was scrolled/updated.Background changes:
onContentUpdatedinstead ofonUpdatedas the later is triggered twice.anchorsonly when the content is updated orisAsideEnabledbecomestrue.scrolllistener when the content has outline disabled orisAsideEnabledbecomesfalse.