Refine logic.

demiankatz · demiankatz · commit 911dea33fd4a · 2025-12-04T08:23:03.000-05:00
diff --git a/module/VuFind/src/VuFind/ServiceManager/AbstractPluginFactory.php b/module/VuFind/src/VuFind/ServiceManager/AbstractPluginFactory.php
@@ -67,8 +67,8 @@ abstract class AbstractPluginFactory implements AbstractFactoryInterface
      */
     protected function getClassName($requestedName)
     {
-        // If we have a FQCN that refers to an existing class, return it as-is:
-        if ((null === $this->defaultNamespace || str_contains($requestedName, '\\')) && class_exists($requestedName)) {
+        // If class name generation is disabled or we have a FQCN that refers to an existing class, return it as-is:
+        if (null === $this->defaultNamespace || (str_contains($requestedName, '\\') && class_exists($requestedName))) {
             return $requestedName;
         }
         // First try the raw service name, then try a normalized version:

Original file line number	Diff line number	Diff line change
`@@ -67,8 +67,8 @@ abstract class AbstractPluginFactory implements AbstractFactoryInterface`
`67`	`67`	`*/`
`68`	`68`	`protected function getClassName($requestedName)`
`69`	`69`	`{`
`70`		`- // If we have a FQCN that refers to an existing class, return it as-is:`
`71`		`- if ((null === $this->defaultNamespace \|\| str_contains($requestedName, '\\')) && class_exists($requestedName)) {`
	`70`	`+ // If class name generation is disabled or we have a FQCN that refers to an existing class, return it as-is:`
	`71`	`+ if (null === $this->defaultNamespace \|\| (str_contains($requestedName, '\\') && class_exists($requestedName))) {`
`72`	`72`	`return $requestedName;`
`73`	`73`	`}`
`74`	`74`	`// First try the raw service name, then try a normalized version:`