Standardize PHPdoc to use bool instead of boolean.

Author: demiankatz

module/VuFind/src/VuFind/Config/YamlReader.php

@@ -80,10 +80,9 @@ public function __construct(
     /**
      * Return a configuration
      *
-     * @param string  $filename       Config file name
-     * @param boolean $useLocalConfig Use local configuration if available
-     * @param boolean $forceReload    Reload even if config has been internally
-     * cached in the class.
+     * @param string $filename       Config file name
+     * @param bool   $useLocalConfig Use local configuration if available
+     * @param bool   $forceReload    Reload even if config has been internally cached in the class.
      *
      * @return array
      */

module/VuFind/src/VuFind/Feature/MergeRecursiveTrait.php

@@ -52,7 +52,7 @@ trait MergeRecursiveTrait
      *
      * @param mixed $op Variable to test
      *
-     * @return boolean
+     * @return bool
      */
     protected function isStringKeyedArray($op)
     {

module/VuFind/src/VuFind/ILS/Driver/Aleph.php

@@ -802,9 +802,9 @@ public function getMyTransactionHistory($user, $params = null)
      * This is responsible for retrieving all transactions (i.e. checked out items)
      * by a specific patron.
      *
-     * @param array   $user    The patron array from patronLogin
-     * @param array   $params  Parameters
-     * @param boolean $history History
+     * @param array $user    The patron array from patronLogin
+     * @param array $params  Parameters
+     * @param bool  $history History
      *
      * @throws DateException
      * @throws ILSException

module/VuFind/src/VuFind/ILS/Driver/Alma.php

@@ -1644,8 +1644,8 @@ public function findReserves($courseID, $instructorID, $departmentID)
     /**
      * Parse a date.
      *
-     * @param string  $date     Date to parse
-     * @param boolean $withTime Add time to return if available?
+     * @param string $date     Date to parse
+     * @param bool   $withTime Add time to return if available?
      *
      * @return string
      */

module/VuFind/src/VuFind/ILS/Driver/PAIA.php

@@ -1954,7 +1954,7 @@ protected function paiaGetUserDetails($patron)
      *
      * @param string $scope The scope to test for with the current session scopes.
      *
-     * @return boolean
+     * @return bool
      */
     protected function paiaCheckScope($scope)
     {

module/VuFind/src/VuFind/Related/Bookplate.php

@@ -156,7 +156,7 @@ protected function getBookplateThumbUrlTemplate()
     /**
      * Display titles under bookplates.
      *
-     * @return boolean
+     * @return bool
      */
     protected function displayBookplateTitles()
     {

module/VuFind/src/VuFind/Search/Base/HierarchicalFacetHelperInterface.php

@@ -44,8 +44,8 @@ interface HierarchicalFacetHelperInterface
      * Helper method for building hierarchical facets:
      * Sort a facet list according to the given sort order
      *
-     * @param array          $facetList Facet list returned from Solr
-     * @param boolean|string $order     Sort order:
+     * @param array       $facetList Facet list returned from Solr
+     * @param bool|string $order     Sort order:
      * - true|top  sort top level alphabetically and the rest by count
      * - false|all sort all levels alphabetically
      * - count     sort all levels by count

module/VuFind/src/VuFind/Search/EDS/AbstractEDSParams.php

@@ -102,7 +102,7 @@ public function createBackendFilterParameters(ParamBag $params)
      *
      * @param string $field Filter field name
      *
-     * @return boolean
+     * @return bool
      */
     protected function filterRequiresFacetOperator($field)
     {

module/VuFind/src/VuFind/Search/Solr/HierarchicalFacetHelper.php

@@ -122,8 +122,8 @@ public function setViewRenderer(RendererInterface $renderer): void
      *
      * Supports both flattened and hierarchical facet lists.
      *
-     * @param array          $facetList Facet list returned from Solr
-     * @param boolean|string $order     Sort order:
+     * @param array       $facetList Facet list returned from Solr
+     * @param bool|string $order     Sort order:
      * - true|top  sort top level alphabetically and the rest by count
      * - false|all sort all levels alphabetically
      * - count     sort all levels by count

module/VuFind/tests/integration-tests/src/VuFindTest/Files/BadStringsTest.php

@@ -51,6 +51,7 @@ class BadStringsTest extends \PHPUnit\Framework\TestCase
      * @var array
      */
     protected array $badStrings = [
+        'non-standard boolean annotation (use bool)' => '/(@(param|return) boolean)/',
         'outdated license address' => '51 Franklin',
         'outdated PHP header comment' => '/\\* (PHP version [^8])\s*\n/',
         'outdated wiki link' => 'vufind.org/wiki/vufind2',