Fix the issue with firewall subcommand

Author: alex-vulnebify

cidre/cli.py

@@ -215,14 +215,14 @@ def main():
         else:
             print_title(cidr_parser)
     elif args.command == "firewall":
-        if args.command in ["allow", "deny", "reject"]:
+        if args.firewall_subcommand in ["allow", "deny", "reject"]:
             joined_countries = ", ".join(args.countries)
             print(
-                f"💡 Applying '{args.command}' action to '{args.firewall.value}' firewall for {joined_countries} countries...",
+                f"💡 Applying '{args.firewall_subcommand}' action to '{args.firewall.value}' firewall for {joined_countries} countries...",
                 end="\n\n",
             )
             success = apply(
-                args.firewall, args.command, args.countries, args.cidr_store
+                args.firewall, args.firewall_subcommand, args.countries, args.cidr_store
             )
             print("")
 

tests/test_cidr.py

@@ -47,3 +47,23 @@ def test_cidr_count():
     assert result.returncode == 0
     assert "US: " in result.stdout
     assert "RU: " in result.stdout
+
+
+def test_firewall_reject():
+    result = subprocess.run(
+        ["cidre", "cidr", "pull", "--merge"],
+        capture_output=True,
+        text=True,
+    )
+    assert result.returncode == 0
+
+    result = subprocess.run(
+        ["cidre", "firewall", "reject", "ru"],
+        capture_output=True,
+        text=True,
+    )
+    assert result.returncode == 0
+    assert (
+        "💡 Applying 'reject' action to 'ufw' firewall for RU countries"
+        in result.stdout
+    )